label nodes with the name of the autoscaling group they belong to#1239
label nodes with the name of the autoscaling group they belong to#1239luckyganesh wants to merge 2 commits intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @luckyganesh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| // integer starting at 1. | ||
| LabelNetworkNodePrefix = "topology.k8s.aws/network-node-layer-" | ||
|
|
||
| LabelAutoScalingGroupName = "node.k8s.aws/auto-scaling-group-name" |
There was a problem hiding this comment.
Did AWS say that this this is OK?
There was a problem hiding this comment.
I have taken it from the issue itself, but incase if we want to change I can do that
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #884
Special notes for your reviewer:
Does this PR introduce a user-facing change?: