fix: lb leak preventing changes in Load Balancer type annotation after creation#1325
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jan 13, 2026
Merged
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
needs-triage
Contributor
|
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/L
mtulio
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
Author
|
Converting to draft til e2e is reviewed and healthy |
Contributor
Author
|
/test all |
Contributor
Author
|
/test pull-cloud-provider-aws-e2e-kubetest2 |
mtulio
changed the title
Adds validation to prevent users from changing the Load Balancer type annotation (service.beta.kubernetes.io/aws-load-balancer-type) after the load balancer has been created. This prevents undefined behavior and potential service disruptions. The validation detects the current load balancer type by analyzing the hostname pattern in the service's LoadBalancer status: - Classic Load Balancer: hostname ends with ".elb.amazonaws.com" - Network Load Balancer: hostname ends with ".elb.<region>.amazonaws.com" If a mismatch is detected between the annotation and the existing load balancer type, the controller returns a validation error preventing the update. Relatest to Issue 1254 Signed-off-by: Claude (AI Assistant) <noreply@anthropic.com> Co-Authored-By: Marco Braga <mrbraga@redhat.com>
mtulio
force-pushed
the
fix-1254-lb-leak
branch
from
d95d41a to
54ac0d6
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
Contributor
Author
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
mtulio
changed the title
k8s-ci-robot
added
the
lgtm
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kmala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
/cherry-pick release-1.34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR adds validation to prevent users from changing the Load Balancer type annotation (
service.beta.kubernetes.io/aws-load-balancer-type) after the load balancer has already been created. This prevents load balancer resource leaks and potential service disruptions that can occur when attempting to change between Classic Load Balancer (CLB) and Network Load Balancer (NLB) after it has been created.The validation works by:
.elb.amazonaws.com.elb.<region>.amazonaws.comWhich issue(s) this PR fixes:
Fixes #1254
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Note: This PR was assisted by Claude (AI Assistant). Implementation authored by Marco Braga (@mtulio).
Signed-off-by: Claude (AI Assistant) noreply@anthropic.com
Co-Authored-By: Marco Braga mtulio@mtulio.dev