Skip to content

Only wait for delayed test queue entries if there is no work#1331

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nrb:fix-tag-timeouts
Jan 20, 2026
Merged

Only wait for delayed test queue entries if there is no work#1331
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nrb:fix-tag-timeouts

Conversation

@nrb
Copy link
Contributor

@nrb nrb commented Jan 16, 2026 •
edited
Loading

What type of PR is this?
/kind flake

What this PR does / why we need it:
CI has been unreliable, reporting failures with the tagging controller tests on unrelated changes.

This is because the previous solution for processing the work queue sleeps after processing every work item, which isn't ideal for responsive tests, and it was resulting in flakes.

Instead, process work as fast as possible, and only sleep when the queue is empty.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The logs for these flakes were analyzed with the help of an AI agent.

Does this PR introduce a user-facing change?:

NONE

@nrb @claude
Only wait for delayed queue if there is no work
8d3200f 
The previous solution for processing the work queue sleeps after
processing every work item, which isn't ideal for responsive tests, and
it was resulting in flakes.

Instead, process work as fast as possible, and only sleep when the queue
is empty.

Note: analysis of the failing logs and the possible fix was assisted by
an "AI" agent.

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 16, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 16, 2026

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2026
@nrb
Copy link
Contributor Author

nrb commented Jan 16, 2026

/test pull-cloud-provider-aws-test

Running again to get more data points for flakes

@damdo
Copy link
Member

damdo commented Jan 17, 2026

/assign @kmala

@damdo
Copy link
Member

damdo commented Jan 17, 2026

/assign @elmiko @JoelSpeed

@nrb
Copy link
Contributor Author

nrb commented Jan 19, 2026

/test pull-cloud-provider-aws-test
/test pull-cloud-provider-aws-e2e-kubetest2

elmiko
elmiko reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, thanks @nrb

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2026
@damdo
Copy link
Member

damdo commented Jan 19, 2026

/test pull-cloud-provider-aws-e2e-kubetest2

@kmala
Copy link
Member

kmala commented Jan 20, 2026

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@k8s-ci-robot k8s-ci-robot merged commit 1243690 into kubernetes:master Jan 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@JoelSpeed JoelSpeed

@kmala kmala

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nrb @k8s-ci-robot @damdo @kmala @elmiko @JoelSpeed