Automated cherry pick of #1207: fix: rule difference for nested objects#1335
Open
kmala wants to merge 2 commits intokubernetes:release-1.29from
Open
Automated cherry pick of #1207: fix: rule difference for nested objects#1335kmala wants to merge 2 commits intokubernetes:release-1.29from
kmala wants to merge 2 commits intokubernetes:release-1.29from
Conversation
The Difference method calculation are returning wrong values on service
update calculating the security group rules.
The core issue is caused by it is always comparing the pointer address,
not the values, always generating difference between lists.
Example:
given s1:{a1, a2} and s2:{a2,a3,a4}
s2.Difference(s1) was returning {a2, a3, a4}, instead {a3, a4}
k8s-ci-robot
added
needs-kind
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
Member
Author
|
/kind bug |
k8s-ci-robot
added
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #1207 on release-1.29.
#1207: fix: rule difference for nested objects
For details on the cherry pick process, see the cherry pick requests page.