Skip to content

Bump go_sdk to 1.25.6 in WORKSPACE#956

Open
DKbyo wants to merge 4 commits intokubernetes:masterfrom
DKbyo:go_1_25_6_workspace
Open

Bump go_sdk to 1.25.6 in WORKSPACE#956
DKbyo wants to merge 4 commits intokubernetes:masterfrom
DKbyo:go_1_25_6_workspace

Conversation

@DKbyo
Copy link

@DKbyo DKbyo commented Jan 23, 2026

Follow up #949 it looks like we missed this configuration file

To achieve this, the following changes were necessary:

  • Migrate io_bazel_rules_go to the latest version.
  • Migrate Bazel to version 6.5.0.
  • Migrate pkg_tar to @rules_pkg//pkg:tar.bzl.
  • Fix e2e tests by adding configmap permissions.
  • Update Makefile due to the new method for running release_tar.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 23, 2026
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @DKbyo!

It looks like this is your first PR to kubernetes/cloud-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DKbyo
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @DKbyo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2026
@elmiko
Copy link
Contributor

elmiko commented Jan 27, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2026
@elmiko
Copy link
Contributor

elmiko commented Jan 27, 2026

i'm not familiar with the WORKSPACE file format, i'm assuming this is part of the bazel process. the change here looks good to me, but will need someone with more experience to approve this.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2026
@DKbyo
Copy link
Author

DKbyo commented Jan 28, 2026

The change is failing because we need a new io_bazel_rules_go that is compatible with go 1.25 see bazel-contrib/rules_go@2af3f27

So I migrated io_bazel_rules_go to the latest version, which required migrating Bazel to 6.5.0 and pkg_tar.

Since you are also working on #953 I don't know if you would like to merge this or wait for the new release-tars

@DKbyo DKbyo force-pushed the go_1_25_6_workspace branch from 07da10f to 811ec64 Compare January 29, 2026 02:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 29, 2026
@DKbyo DKbyo force-pushed the go_1_25_6_workspace branch from 811ec64 to 303ae76 Compare February 3, 2026 18:51
@DKbyo DKbyo marked this pull request as draft February 3, 2026 20:13
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2026
@DKbyo
Copy link
Author

DKbyo commented Feb 3, 2026

/retest

1 similar comment
@DKbyo
Copy link
Author

DKbyo commented Feb 4, 2026

/retest

@DKbyo
Copy link
Author

DKbyo commented Feb 4, 2026

I added more logs and the error in the test are:

NAME                                                READY   STATUS             RESTARTS        AGE   IP       NODE                                  NOMINATED NODE   READINESS GATES
cloud-controller-manager-kt2-ee64a5a6-3614-master   0/1     CrashLoopBackOff   11 (42s ago)    31m   <none>   kt2-ee64a5a6-3614-master              <none>           <none>

After replicating this on my local I found the error on cloud-controller-manager is:

W0204 03:15:04.290911      11 requestheader_controller.go:204] Unable to get configmap/extension-apiserver-authentication in kube-system.  Usually fixed by 'kubect
l create rolebinding -n kube-system ROLEBINDING_NAME --role=extension-apiserver-authentication-reader --serviceaccount=YOUR_NS:YOUR_SA'
unable to load configmap based request-header-client-ca-file: configmaps "extension-apiserver-authentication" is forbidden: User "system:cloud-controller-manager" 
cannot get resource "configmaps" in API group "" in the namespace "kube-system"
Error: unable to load configmap based request-header-client-ca-file: configmaps "extension-apiserver-authentication" is forbidden: User "system:cloud-controller-ma
nager" cannot get resource "configmaps" in API group "" in the namespace "kube-system"

@DKbyo
Copy link
Author

DKbyo commented Feb 4, 2026

This can also be seen on prow

Looks like we have faced this issue in the past, not sure what was the fix then #802 (comment)

@DKbyo DKbyo force-pushed the go_1_25_6_workspace branch from f9022b6 to f9aed62 Compare February 5, 2026 20:50
@DKbyo
Copy link
Author

DKbyo commented Feb 5, 2026

/retest

1 similar comment
@DKbyo
Copy link
Author

DKbyo commented Feb 5, 2026

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2026
@DKbyo DKbyo force-pushed the go_1_25_6_workspace branch from fc5cbe1 to e5ca394 Compare February 6, 2026 14:46
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2026
@DKbyo
Copy link
Author

DKbyo commented Feb 6, 2026

/retest

1 similar comment
@DKbyo
Copy link
Author

DKbyo commented Feb 6, 2026

/retest

@DKbyo DKbyo marked this pull request as ready for review February 6, 2026 16:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2026
@DKbyo DKbyo force-pushed the go_1_25_6_workspace branch from e5ca394 to b592f91 Compare February 11, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants