-
Notifications
You must be signed in to change notification settings - Fork 629
[cinder-csi-plugin]: ResourceExhausted code for CreateVolume #2860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Welcome @hown3d! |
Hi @hown3d. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If Openstack quotas for volumes are exceeded, cinder returns with a HTTP 413 response code: https://github.com/openstack/cinder/blob/c4f61c11ef9b590606a2a276bdf256622516181f/cinder/quota_utils.py#L130-L140 CSI spec defines that on a quota limit error, the driver should return a ResourceExhausted grpc error code: https://github.com/container-storage-interface/spec/blob/master/spec.md#createvolume-errors Signed-off-by: Lukas Hoehl <[email protected]>
/test openstack-cloud-controller-manager-ovn-e2e-test |
@zetaab i have a pending merge request for a while can some give use help for this Create one storage cluster for wide spreaded kubernetes cluster in many Azs |
What this PR does / why we need it:
If OpenStack quotas for volumes are exceeded, the driver currently returns the gRPC call with code
Internal
. This is not propagated to the PVC as an event and is not traceable very easily.Cinder returns with a HTTP 413 response code if the quota for volumes is exceeded:
https://github.com/openstack/cinder/blob/c4f61c11ef9b590606a2a276bdf256622516181f/cinder/quota_utils.py#L130-L140
CSI spec defines that on a quota limit error, the driver should return a
ResourceExhausted
grpc error code:https://github.com/container-storage-interface/spec/blob/master/spec.md#createvolume-errors
Release note: