feat: add rhel8/9/10 to guest os list

[MindTooth]

What this PR does / why we need it:

Today we only see vsphere-vm.cpu-4.mem-16gb.os-unknown as guest OS name:

---

---

Taken from this list: https://knowledge.broadcom.com/external/article/321876/determine-the-guest-os-from-a-vm-configu.html

Note! RHEL 9 needs compatibility profile 18 or higher.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

N/A

Special notes for your reviewer:

I also see that setting the type string is only done at discovery. IMHO, it should have been reconciled because you might scale the nodes via vSphere.

cloud-provider-vsphere/pkg/cloudprovider/vsphere/nodemanager.go

Line 367 in a7f0c5c

instanceType := fmt.Sprintf("vsphere-vm.cpu-%d.mem-%dgb.os-%s",

Release note:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: MindTooth / name: Birger Johan Nordølum (58ab86d)

[k8s-ci-robot]

Welcome @MindTooth!

It looks like this is your first PR to kubernetes/cloud-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @MindTooth. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zhanggbj]

/ok-to-test

[MindTooth]

Do you think it will be okay to add rhel10_64Guest also, now that RHEL 10 officially announced? I see that it's added to vSphere yet by VMware, but could be a future proofing.

[MindTooth]

Do you think it will be okay to add rhel10_64Guest also, now that RHEL 10 officially announced? I see that it's added to vSphere yet by VMware, but could be a future proofing.

Support for RHEL 10 is now added to vSphere 9.0.

https://techdocs.broadcom.com/us/en/vmware-cis/vcf/vcf-9-0-and-later/9-0/release-notes/vmware-cloud-foundation-90-release-notes/platform-whats-new/whats-new-vsphere.html#GUID-9bfea8cc-6a54-448f-874f-f8e4f5bbe4ac-en_id-04c8dc53-9df2-4702-92be-0b318a8531d6

https://developer.broadcom.com/xapis/vsphere-web-services-api/latest/vim.vm.GuestOsDescriptor.GuestOsIdentifier.html

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MindTooth
Once this PR has been reviewed and has the lgtm label, please assign skriss for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[MindTooth]

/remove-lifecycle stale