Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 100mik The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @100mik! |
|
Hi @100mik. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| return nil, err | ||
| } | ||
|
|
||
| supervisorHostname := SupervisorAPIServerFQDN |
There was a problem hiding this comment.
This looks like a back door, I prefer to add hostName and port in CPI Config file. When they are empty, use SupervisorAPIServerFQDN as default.
What this PR does / why we need it:
Allows folks to configure an override for the hardcoded hostname, this enables cases like allowing CPI to speak with the API server through a VCF A proxy.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1709Special notes for your reviewer:
Release note: