-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[WIP] github-management: add rotation program #6185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idvoretskyi, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
## Rotation Schedule | ||
|
||
You can find the rotation schedule and the current rotating member at this [calendar]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's an easier way of handling the rotation schedule.
@mrbobbytables do you think it'd be feasible to publish this to k8s.dev? Similar to how https://www.kubernetes.dev/resources/calendar/ works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the test-infra-oncall (http://go.k8s.io/oncall) uses but that looks pretty cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the test-infra-oncall (http://go.k8s.io/oncall) uses
The data source is at https://storage.googleapis.com/kubernetes-jenkins/oncall.json. Afaik https://github.com/kubernetes/test-infra/blob/master/maintenance/oncall.html is used to display the oncall data at http://go.k8s.io/oncall and slack-oncall-updater is used to automatically update the @test-infra-oncall
slack usergroup.
I'm not sure how https://storage.googleapis.com/kubernetes-jenkins/oncall.json is generated/updated though. @spiffxp @BenTheElder do you know?
We could do something similar for github-management but we'll need to be even more explicit that this is not an oncall role. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how https://storage.googleapis.com/kubernetes-jenkins/oncall.json is generated/updated though.
I'm curious about this as well.
we'll need to be even more explicit that this is not an oncall role.
+100. Naming and communication should be structured very differently since the rotation program is about rotating responsibilities keeping the existing SLOs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re:calendar, it pulls in details from any of the sig/wg calendars ([email protected] just has to be invited).
We could either use the contribex calendar or create a new one and make sure [email protected] is invited to all events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSON file is published by a Borg job pulling info from Google's oncall system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: since this conversation started, I've turned down https://go.k8s.io/oncall. We've moved away from that model entirely. (it serves a page directing you to relevant slack channels #testing-ops and #sig-scalability)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW SRC is actively running an oncall rotation, so that might be a better starting point than the former k8s-infra-oncall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
af8ec90
to
9acb2c0
Compare
New changes are detected. LGTM label has been removed. |
|
||
## Rotation Schedule | ||
|
||
You can find the rotation schedule and the current rotating member at this [calendar]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the test-infra-oncall (http://go.k8s.io/oncall) uses but that looks pretty cool.
This commit adds a rotation program for both GitHub Admins and NMCs to create a sustainable culture and avoid burn out. This is also important to ensure that requests from community members are handled as per our SLO of one week. Note that this is not an oncall program. Our SLO continues to remain one week.
9acb2c0
to
718c899
Compare
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten /unassign @idvoretskyi @fejta @ameukam @savitharaghunathan |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten @kubernetes/owners, for planning in early 2025. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
This commit adds a rotation program for both GitHub Admins and NMCs
to create a sustainable culture and avoid burn out. This is also
important to ensure that requests from community members are handled
as per our SLO of one week.
Note that this is not an oncall program. Our SLO continues to remain
one week.
This was discussed in GitHub Management meeting on 2 September 2021.
This is WIP because we still need to create the rotation calendar and publish it.
/assign @cblecker @spiffxp @mrbobbytables @idvoretskyi @fejta
github admins
/assign @palnabarun @ameukam @savitharaghunathan
NMCs