release: document kind/deprecation #7600

skitt · 2023-11-06T12:08:55Z

This appears in the PR templates but isn't documented. Since it enforces release notes, it's presumably intended for PRs deprecating APIs rather than for PRs fixing deprecated usage.

Which issue(s) this PR fixes:

Fixes #

This appears in the PR templates but isn't documented. Since it enforces release notes, it's presumably intended for PRs deprecating APIs rather than for PRs fixing deprecated usage. Signed-off-by: Stephen Kitt <[email protected]>

k8s-ci-robot · 2023-11-06T12:09:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skitt
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

contributors/devel/sig-release/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pohly · 2023-11-06T12:52:39Z

contributors/devel/sig-release/release.md

@@ -337,6 +337,7 @@ issue kind labels must be set:
 - `kind/api-change`: Adds, removes, or changes an API
 - `kind/bug`: Fixes a newly discovered bug.
 - `kind/cleanup`: Adding tests, refactoring, fixing old bugs.
+- `kind/deprecation`: Deprecates an API (release notes required).


One thing that comes up from time to time is whether release notes need to be added for Go API changes - this is particularly relevant for deprecations of Go APIs when this kind is used: kubernetes/kubernetes#120567 (comment)

Perhaps we can use PR to also elaborate on that aspect?

My own take: I add release notes for Go API changes when they seem significant enough, but not for everything.

Given the general terseness of this document, wouldn’t that be better in https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md?

Yes. Could still be in this PR, though, because it is related as seen when @neolit123 tried to use kind/deprecation.

my feedback:

kind deprecation should not require a release-note. it seems like a guard rail for lack of release notes; release notes should be in place regardless. if maintainers are not asking for them, then we have a wider problem.

reading into the label without context, kind deprecation is about anything that is being deprecated; examples: a document, a test, some code that only maintainers care about, an API. so not only about APIs.

if we want a specialized label for APIs it can be kind api-deprecation

the release notes team should only process kind/*deprecation labels when a release note is added...because that is a user facing deprecation

@neolit123 I take it you’re saying we should fix the process, and document the fixed process, rather than document a flawed process; is that correct? (Assuming enough stakeholders agree that the process is flawed.)

yeah, that's my take.

Hey folks 👋

I want to check first, what's the status of this PR? Do you need any help from SIG Release to move it forward?

My 2 cents are (tl;dr) that I in large agree with @neolit123 here:

kind/deprecation should not be used only for APIs, instead it should be about anything user-facing. I'd rather phrase this as deprecates a user facing feature (e.g. API, command...)

I'd keep release note required out of this document, instead it should be part of the release notes document linked above

I also agree about not requiring the release note for deprecations, but with a little conflict. I would prefer (at least in some of mentioned cases) using kind/cleanup if we're talking about non-user facing things. For example: tests, documentation for maintainers; I think all of that is kind of covered by kind/cleanup already, or it can be more-or-less easily extended to cover that.

To add on this, I think there's a couple of things that we lack in the process. For example, kind/deprecation is used for removals at the moment and I find this wrong. Deprecation is more like announcing intention to stop supporting something followed by its removal, or just announcing its removal. Ideally, I think we should consider adding some additional labels, but we would have to involve all stakeholders before changing this (different SIGs, Leads, and the Release Team).

k8s-triage-robot · 2024-02-07T08:51:41Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-03-08T09:36:21Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

skitt · 2024-03-08T09:48:39Z

/remove-lifecycle rotten

k8s-triage-robot · 2024-06-06T10:28:30Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-07-06T10:55:42Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

pohly · 2024-07-11T15:06:14Z

/remove-lifecycle rotten

justaugustus · 2024-08-05T10:04:19Z

Assigning our subproject leads for review:
/assign @katcosgrove @gracenng @xmudrii
/unassign @justaugustus @jeremyrickard

justaugustus · 2024-08-05T10:05:15Z

/uncc @justaugustus @jeremyrickard

k8s-triage-robot · 2024-11-28T09:51:13Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pohly · 2024-11-28T13:41:55Z

/remove-lifecycle rotten

xmudrii · 2024-11-28T15:08:13Z

/remove-lifecycle stale

k8s-triage-robot · 2025-02-26T15:57:16Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-03-28T16:11:13Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

release: document kind/deprecation

6380343

This appears in the PR templates but isn't documented. Since it enforces release notes, it's presumably intended for PRs deprecating APIs rather than for PRs fixing deprecated usage. Signed-off-by: Stephen Kitt <[email protected]>

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2023

k8s-ci-robot requested a review from jeremyrickard November 6, 2023 12:09

k8s-ci-robot requested a review from justaugustus November 6, 2023 12:09

k8s-ci-robot added area/developer-guide Issues or PRs related to the developer guide sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 6, 2023

pohly reviewed Nov 6, 2023

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 8, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 8, 2024

justaugustus mentioned this pull request Jun 3, 2024

sig-release: Add subproject leads as reviewers/approvers for subdirs #7926

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 6, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 11, 2024

k8s-ci-robot assigned gracenng, katcosgrove and xmudrii Aug 5, 2024

k8s-ci-robot removed the request for review from justaugustus August 5, 2024 10:05

k8s-ci-robot removed the request for review from jeremyrickard August 5, 2024 10:05

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: document kind/deprecation #7600

release: document kind/deprecation #7600

skitt commented Nov 6, 2023

k8s-ci-robot commented Nov 6, 2023

pohly Nov 6, 2023

skitt Nov 8, 2023

pohly Nov 9, 2023

neolit123 Nov 9, 2023 •

edited

Loading

skitt Nov 9, 2023

neolit123 Nov 9, 2023

xmudrii Aug 30, 2024

k8s-triage-robot commented Feb 7, 2024

k8s-triage-robot commented Mar 8, 2024

skitt commented Mar 8, 2024

k8s-triage-robot commented Jun 6, 2024

k8s-triage-robot commented Jul 6, 2024

pohly commented Jul 11, 2024

justaugustus commented Aug 5, 2024

justaugustus commented Aug 5, 2024

k8s-triage-robot commented Nov 28, 2024

pohly commented Nov 28, 2024

xmudrii commented Nov 28, 2024

k8s-triage-robot commented Feb 26, 2025

k8s-triage-robot commented Mar 28, 2025

release: document kind/deprecation #7600

Are you sure you want to change the base?

release: document kind/deprecation #7600

Conversation

skitt commented Nov 6, 2023

k8s-ci-robot commented Nov 6, 2023

pohly Nov 6, 2023

Choose a reason for hiding this comment

skitt Nov 8, 2023

Choose a reason for hiding this comment

pohly Nov 9, 2023

Choose a reason for hiding this comment

neolit123 Nov 9, 2023 • edited Loading

Choose a reason for hiding this comment

skitt Nov 9, 2023

Choose a reason for hiding this comment

neolit123 Nov 9, 2023

Choose a reason for hiding this comment

xmudrii Aug 30, 2024

Choose a reason for hiding this comment

k8s-triage-robot commented Feb 7, 2024

k8s-triage-robot commented Mar 8, 2024

skitt commented Mar 8, 2024

k8s-triage-robot commented Jun 6, 2024

k8s-triage-robot commented Jul 6, 2024

pohly commented Jul 11, 2024

justaugustus commented Aug 5, 2024

justaugustus commented Aug 5, 2024

k8s-triage-robot commented Nov 28, 2024

pohly commented Nov 28, 2024

xmudrii commented Nov 28, 2024

k8s-triage-robot commented Feb 26, 2025

k8s-triage-robot commented Mar 28, 2025

neolit123 Nov 9, 2023 •

edited

Loading