Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions contributors/devel/sig-testing/e2e-tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -544,13 +544,6 @@ stragglers to finish.
takes too many resources or restarts nodes), it is labeled `[Serial]`, and
should be run in serial as part of a separate suite.

- `[Disruptive]`: If a test may impact workloads that it didn't create,
it should be marked as `[Disruptive]`. Examples of disruptive behavior
include, but are not limited to, restarting components or tainting nodes. Any
`[Disruptive]` test is also assumed to qualify for the `[Serial]` label, but
need not be labeled as both. These tests are not run against soak clusters to
avoid restarting components.

- `[Flaky]`: If a test is found to be flaky and we have decided that it's too
hard to fix in the short term (e.g. it's going to take a full engineer-week), it
receives the `[Flaky]` label until it is fixed. The `[Flaky]` label should be
Expand Down Expand Up @@ -760,12 +753,12 @@ against GCE and GKE. To minimize the time from regression-to-green-run, we
partition tests across different jobs:

- `kubernetes-e2e-<provider>` runs all non-`[Slow]`, non-`[Serial]`,
non-`[Disruptive]`, non-`[Flaky]`, non-`[Feature:.+]` tests in parallel.
non-`[Flaky]`, non-`[Feature:.+]` tests in parallel.

- `kubernetes-e2e-<provider>-slow` runs all `[Slow]`, non-`[Serial]`,
non-`[Disruptive]`, non-`[Flaky]`, non-`[Feature:.+]` tests in parallel.
non-`[Flaky]`, non-`[Feature:.+]` tests in parallel.

- `kubernetes-e2e-<provider>-serial` runs all `[Serial]` and `[Disruptive]`,
- `kubernetes-e2e-<provider>-serial` runs all `[Serial]`,
non-`[Flaky]`, non-`[Feature:.+]` tests in serial.

- `ci-kubernetes-e2e-kind-alpha-features` runs all tests without any special
Expand All @@ -791,7 +784,7 @@ default.

We also run a battery of tests against every PR before we merge it. These tests
are equivalent to `kubernetes-gce`: it runs all non-`[Slow]`, non-`[Serial]`,
non-`[Disruptive]`, non-`[Flaky]`, non-`[Feature:.+]` tests in parallel. These
non-`[Flaky]`, non-`[Feature:.+]` tests in parallel. These
tests are considered "smoke tests" to give a decent signal that the PR doesn't
break most functionality. Results for your PR can be found at
[pr-test.k8s.io](http://pr-test.k8s.io), e.g.
Expand Down
6 changes: 3 additions & 3 deletions contributors/devel/sig-testing/writing-good-e2e-tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ or upgrading cluster software as part of your test is likely to
violate the assumptions that other tests might have made about a
reasonably stable cluster environment. If you need to write such
tests, please label them as
["\[Disruptive\]"](e2e-tests.md#kinds-of-tests) so that it's easy to
["\[Serial\]"](e2e-tests.md#kinds-of-tests) so that it's easy to
identify them, and not run them in parallel with other tests.
1. You should avoid making assumptions about the Kubernetes API that
are not part of the API specification, as your tests will break as
Expand Down Expand Up @@ -526,7 +526,7 @@ descriptors:
and

```
Nodes [Disruptive] Network when a node becomes unreachable
Nodes [Serial] Network when a node becomes unreachable
[replication controller] recreates pods scheduled on the
unreachable node AND allows scheduling of pods on a node after
it rejoins the cluster
Expand All @@ -535,7 +535,7 @@ it rejoins the cluster
An improvement might be

```
Unreachable nodes are evacuated and then repopulated upon rejoining [Disruptive]
Unreachable nodes are evacuated and then repopulated upon rejoining [Serial]
```

Note that opening issues for specific better tooling is welcome, and
Expand Down