-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer Social Icons #568
base: master
Are you sure you want to change the base?
Footer Social Icons #568
Conversation
Signed-off-by: Chris "Not So" Short <[email protected]>
/assign sftim |
I had tried doing the same, upgrading FontAwesome doesn't work cause Docsy FA dependency is shadowing the explicit dependency. |
Let me know if you want this reviewed @chris-short |
Bluesky is going to take some extra work but, @sftim this is ready for review along with kubernetes/website#49594 |
- name: Bluesky | ||
url: 'https://bsky.app/profile/kubernetes.dev' | ||
icon: fab fa-bluesky | ||
desc: Follow us on Bluesky to get the latest news! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we merge this before the Bluesky icon works? I'm unsure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One less thing to change later. I'm indifferent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you drop it, I can definitely merge the change @chris-short. I feel like adding a broken link to Bluesky is technical debt (and potentially a source of issues, etc).
Signed-off-by: Chris "Not So" Short <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chris-short The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Apologies for the nitpick, but could you revert the lock file too? |
Signed-off-by: Chris "Not So" Short <[email protected]>
Done! @SayakMukhopadhyay @sftim |
/lgtm |
Signed-off-by: Chris "Not So" Short [email protected]