Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Social Icons #568

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chris-short
Copy link
Contributor

  1. Removed X/Twitter
  2. Added LinkedIn and Mastodon to footer
  3. Updated the FontAwesome dependency to add Bluesky but could not get the Bluesky icon to display despite the code being in the HTML output

Signed-off-by: Chris "Not So" Short [email protected]

Signed-off-by: Chris "Not So" Short <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2025
@chris-short
Copy link
Contributor Author

/assign sftim

@SayakMukhopadhyay
Copy link
Contributor

I had tried doing the same, upgrading FontAwesome doesn't work cause Docsy FA dependency is shadowing the explicit dependency.

@sftim
Copy link
Contributor

sftim commented Jan 30, 2025

Let me know if you want this reviewed @chris-short

@chris-short chris-short marked this pull request as ready for review January 30, 2025 11:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2025
@chris-short
Copy link
Contributor Author

Bluesky is going to take some extra work but, @sftim this is ready for review along with kubernetes/website#49594

Comment on lines +159 to +162
- name: Bluesky
url: 'https://bsky.app/profile/kubernetes.dev'
icon: fab fa-bluesky
desc: Follow us on Bluesky to get the latest news!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge this before the Bluesky icon works? I'm unsure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One less thing to change later. I'm indifferent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you drop it, I can definitely merge the change @chris-short. I feel like adding a broken link to Bluesky is technical debt (and potentially a source of issues, etc).

package.json Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chris-short
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SayakMukhopadhyay
Copy link
Contributor

Apologies for the nitpick, but could you revert the lock file too?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2025
@chris-short
Copy link
Contributor Author

Done! @SayakMukhopadhyay @sftim

@SayakMukhopadhyay
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants