Promote /welcome content to root index and update featured images#616
Promote /welcome content to root index and update featured images#616TineoC wants to merge 2 commits intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TineoC The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
a348c3a to
f6721cd
Compare
|
/priority high |
|
@TineoC: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you for the work on this, given the importance of the frontpage it'd be nice to get input/approval from SIG leads: @mfahlandt @kaslin and @palnabarun. |
|
Apologies for non-review, problem with my GH notifications. Gonna try to clear out the backlog. |
|
So, is there discussion somewhere about changing the image? While I appreciate featuring one of my cups, I'm not clear on why the swap. |
https://www.kubernetes.dev/welcome/ is the current background image, so we're not technically changing the image. The image path had to change was required so it's targeting the index page. |
|
/lgtm |
Description
This PR promotes the welcome page content to the root index page and updates the featured background images used across the site.
Changes
/welcomecontent to root_index.mdcontributor-summit-2018.jpg(removed from active use)Related Issues
Closes #614