Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reasonable --image-gc-high-threshold #4739

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

reasonable --image-gc-high-threshold #4739

wants to merge 2 commits into from

Conversation

olderTaoist
Copy link

@olderTaoist olderTaoist commented Jun 19, 2024 •
edited
Loading

KEP-4120: add ImageGCBeforeStorageEviction feature gate to kubelet

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @olderTaoist. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2024
@olderTaoist
Copy link
Author

@haircommander @SergeyKanzhelev discuss here

@olderTaoist olderTaoist mentioned this pull request Jun 19, 2024
Closed
@bart0sh
Copy link
Contributor

bart0sh commented Jun 25, 2024

/ok-to-test
/cc @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 26, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 26, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 26, 2024
@olderTaoist olderTaoist requested a review from haircommander July 1, 2024 10:49
@olderTaoist
Copy link
Author

@haircommander @SergeyKanzhelev PTAL

haircommander
haircommander reviewed Jul 17, 2024
View reviewed changes
keps/sig-node/4727-reasonable-image-gc/README.md
- Impact of its outage on the feature:
- Impact of its degraded performance or high-error rates on the feature:
-->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll want to put N/A for any section that's not relevant, but some of these may be.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

haircommander
haircommander reviewed Jul 17, 2024
View reviewed changes
keps/sig-node/4727-reasonable-image-gc/kep.yaml Outdated

approvers:
- "@haircommander"
- "@SergeyKanzhelev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need a sig node approver for this, but we won't determine that until 1.32 cycle begins, so we needn't update it now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i change to TBD

@olderTaoist olderTaoist force-pushed the image-gc branch 2 times, most recently from 022a7da to ee590a2 Compare July 18, 2024 13:13
@olderTaoist
Copy link
Author

@SergeyKanzhelev @haircommander PTAL

HirazawaUi
HirazawaUi reviewed Aug 3, 2024
View reviewed changes
keps/sig-node/4727-reasonable-image-gc/README.md Outdated
## Design Details

Add `ImageGCBeforeStorageEviction` feature gate to kubelet.
When the feature is turned on, the value of `--image-gc-high-threshold` must be smaller than value of `100 - imagefs.available`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the value of --image-gc-high-threshold is not less than "100 - imagefs.available", what will kubelet do? Will it panic, or will this field become ineffective? Can you explain this in detail here?

keps/sig-node/4727-reasonable-image-gc/README.md Outdated
##### Unit tests


- `pkg/kubelet/apis/config/validation`: `-:-:-` - `0%`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the test coverage 0%? The test coverage of the latest master branch is 97.1%.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just figured out what Unit tests means. already updated as https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit stated.

keps/sig-node/4727-reasonable-image-gc/README.md Outdated
## Design Details

Add `ImageGCBeforeStorageEviction` feature gate to kubelet.
When the feature is turned on, the value of `--image-gc-high-threshold` must be smaller than value of `100 - imagefs.available`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we change the default value of --image-gc-high-threshold? What will it be changed to? Please also explain this here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@olderTaoist olderTaoist requested a review from HirazawaUi August 9, 2024 01:35
@olderTaoist
Copy link
Author

@haircommander @SergeyKanzhelev @HirazawaUi PTAL

@olderTaoist
Copy link
Author

Can someone take a look? @bart0sh @SergeyKanzhelev @haircommander @sftim @HirazawaUi

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2024
@haircommander haircommander mentioned this pull request Jan 22, 2025
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 25, 2025
@SergeyKanzhelev
Copy link
Member

@haircommander do you think we need this KEP? Can this be a part of a GC threshold KEP itself?

@haircommander
Copy link
Contributor

Can this be a part of a GC threshold KEP itself?

WDYM? do we have one already?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HirazawaUi
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 6, 2025
@k8s-ci-robot
Copy link
Contributor

@HirazawaUi: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olderTaoist
Once this PR has been reviewed and has the lgtm label, please assign dchen1107, jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@sftim sftim Awaiting requested review from sftim

@haircommander haircommander Awaiting requested review from haircommander

@HirazawaUi HirazawaUi Awaiting requested review from HirazawaUi

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@olderTaoist @k8s-ci-robot @bart0sh @k8s-triage-robot @SergeyKanzhelev @haircommander @HirazawaUi @sftim