Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-5018: DRA: AdminAccess for ResourceClaims and ResourceClaimTemplates #5019

Merged
merged 10 commits into from
Feb 12, 2025
Merged

KEP-5018: DRA: AdminAccess for ResourceClaims and ResourceClaimTemplates #5019

merged 10 commits into from
Feb 12, 2025

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Jan 3, 2025

  • One-line PR description: DRAAdminAccess: allow creations of ResourceClaims and ResourceClaimTemplates in privileged mode to grant access to devices that are in use by other users for admin tasks like monitor health or status of the device.
  • Other comments:

NOTE: The DRAAdminAccess feature was initially part of https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4381-dra-structured-parameters In 1.32, the DRAAdminAccess feature gate was added to keep the adminAccess field in alpha while promoting structured parameters to beta. It was discussed this feature should be part of a separate KEP to push it forward. Most references to DRAAdminAccess are removed from the original KEP and moved to this KEP.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 3, 2025
@kubernetes kubernetes deleted a comment from k8s-ci-robot Jan 3, 2025
@ritazh
Copy link
Member Author

ritazh commented Jan 3, 2025

/assign @pohly

@ritazh
Copy link
Member Author

ritazh commented Jan 3, 2025

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jan 3, 2025
@ritazh
Copy link
Member Author

ritazh commented Jan 6, 2025

/sig node

nojnhuh
nojnhuh reviewed Jan 7, 2025
View reviewed changes
pohly
pohly reviewed Jan 8, 2025
View reviewed changes
@towca towca mentioned this pull request Jan 9, 2025
Open
@enj enj self-assigned this Jan 15, 2025
@liggitt liggitt added the api-review Categorizes an issue or PR as actively needing an API review. label Jan 16, 2025
ritazh added 2 commits February 3, 2025 19:09
@ritazh
address comments
d8ed710 
Signed-off-by: Rita Zhang <[email protected]>
@ritazh
Add PRR
000e6ff 
Signed-off-by: Rita Zhang <[email protected]>
@ritazh
Copy link
Member Author

ritazh commented Feb 4, 2025

Please add a PRR file to request PRR review.

Added. @kannon92 do you know who we should tag for PRR?

@kannon92
Copy link
Contributor

kannon92 commented Feb 4, 2025

Please add a PRR file to request PRR review.

Added. @kannon92 do you know who we should tag for PRR?

Oh I’m not actually sure. I’ve always used @johnbelamaric for node related KEPs but there was an agenda item to find someone else to look at it from PRR..

Maybe post on the #prod-readiness slack?

@soltysh
Copy link
Contributor

soltysh commented Feb 4, 2025

Added. @kannon92 do you know who we should tag for PRR?

As discussed on slack, I'll pick that up from PRR perspective.

@ritazh
Copy link
Member Author

ritazh commented Feb 4, 2025

/wg device-management

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Feb 4, 2025
enj
enj reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass.

soltysh
soltysh reviewed Feb 6, 2025
View reviewed changes
@ritazh
address comments
94bf684 
Signed-off-by: Rita Zhang <[email protected]>
@ritazh
Copy link
Member Author

ritazh commented Feb 8, 2025

I've addressed all your comments @soltysh @enj PTAL thank you!

soltysh
soltysh approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, but PRR looks good.
/approve

@ritazh
add mermaid flowchart
f76ea34 
Signed-off-by: Rita Zhang <[email protected]>
pohly
pohly reviewed Feb 10, 2025
View reviewed changes
keps/sig-auth/5018-dra-adminaccess/kep.yaml Outdated
- "@enj"
approvers:
- "@enj"
- # SIG-Node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyKanzhelev, @mrunalp: can one of you approve for SIG Node?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add me here.

enj
enj reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on the mermaid diagram, LGTM.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@ritazh
add mermaid flowchart
f5e7b87 
Signed-off-by: Rita Zhang <[email protected]>
@ritazh
add sig node approver
9a0f12e 
Signed-off-by: Rita Zhang <[email protected]>
@enj
Copy link
Member

enj commented Feb 12, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mrunalp, ritazh, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 507f0cb into kubernetes:master Feb 12, 2025
3 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 12, 2025
@ritazh ritazh deleted the dra-admin-access branch February 12, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@liggitt liggitt liggitt left review comments

@jackfrancis jackfrancis jackfrancis left review comments

@kannon92 kannon92 kannon92 left review comments

@enj enj enj requested changes

@deads2k deads2k deads2k left review comments

@nojnhuh nojnhuh nojnhuh left review comments

@mrunalp mrunalp mrunalp approved these changes

@soltysh soltysh soltysh approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@pohly pohly

@enj enj

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
API Reviews
Status: API review completed, 1.33
SIG Auth
Status: Closed / Done
SIG Node: Dynamic Resource Allocation
Status: ✅ Done
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.