Skip to content

KEP-3751: Update release signoff Checklist before GA #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

KEP-3751: Update release signoff Checklist before GA #5024

merged 1 commit into from
Jun 9, 2025

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Jan 7, 2025 •
edited
Loading

  • One-line PR description: Update Release Signoff Checklist
  • Issue link:

/assign @msau42

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2025
@xing-yang
Copy link
Contributor

  • Can you change the title "Kubernetes Volume Provisioned IO" to "Kubernetes Modify Volume" or "Kubernetes Volume Attributes Class"? It is not just about "provisioned io" any more.

  • "Stress test before GA" is in the Beta section. Do we have stress test?

  • This is in the PRR section "TODO Upgrade and rollback will be tested when the feature gate will change to beta." Is this still a TODO?

@xing-yang
Copy link
Contributor

It looks like this PR does not contain this merged change: https://github.com/kubernetes/enhancements/pull/5028/files
Do you need a rebase?

@sftim
Copy link

sftim commented Jan 22, 2025

/retitle KEP-3751: Update release signoff Checklist before GA

@k8s-ci-robot k8s-ci-robot changed the title Update Release Signoff Checklist for KEP-3751 before GA KEP-3751: Update release signoff Checklist before GA Jan 22, 2025
@sunnylovestiramisu
Copy link
Contributor Author

/assign johnbelamaric

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2025
@sunnylovestiramisu
Copy link
Contributor Author

Stress tests still WIP: kubernetes/kubernetes#129918

It is set at a low rate though similar to our other stress tests(10 pods), and creating pod+volume, and then modify the volume.

xing-yang
xing-yang reviewed Feb 4, 2025
View reviewed changes
gnufied
gnufied reviewed Feb 5, 2025
View reviewed changes
@sunnylovestiramisu sunnylovestiramisu force-pushed the updateVAC branch 3 times, most recently from 0bfdef2 to 61c778e Compare February 6, 2025 16:01
@johnbelamaric
Copy link
Member

Ok, I see the stress test is in progress, I would expect that do be done as part of this GA. The other PRR answers seem good. Once there is SIG approval, I can add the approval.

@carlory carlory mentioned this pull request Apr 30, 2025
Open
carlory
carlory reviewed Apr 30, 2025
View reviewed changes
@sunnylovestiramisu sunnylovestiramisu force-pushed the updateVAC branch 3 times, most recently from f9bec7a to b9020e2 Compare June 3, 2025 23:31
msau42
msau42 reviewed Jun 6, 2025
View reviewed changes
@msau42
Copy link
Member

msau42 commented Jun 6, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2025
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Jun 6, 2025
Open
20 tasks
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2025
johnbelamaric
johnbelamaric reviewed Jun 6, 2025
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor points, I will approve now but please make those small changes before LGTM

/approve

keps/sig-storage/3751-volume-attributes-class/README.md Outdated
@@ -837,14 +857,37 @@ If the feature is rolled out partially on API servers, there will be no impact o
be processed as if the feature is disabled, the external-provisioner/external-resizer is not acting on the event created yet - that means nothing happens and PVC
will not be changed with the iops/throughput until external-provisioner/external-resizer is deployed.

###### How can a rollout or rollback fail? Can it impact already running workloads?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already answered above?

Could enabling the feature cause api server, kcm, or the external provisioner to crash - I think it could if there were bugs. In that case, crashes in those should inform a rollback. Please add that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I did not notice it is repeated. Removed this.

keps/sig-storage/3751-volume-attributes-class/README.md
@@ -837,14 +857,37 @@ If the feature is rolled out partially on API servers, there will be no impact o
be processed as if the feature is disabled, the external-provisioner/external-resizer is not acting on the event created yet - that means nothing happens and PVC
will not be changed with the iops/throughput until external-provisioner/external-resizer is deployed.

###### How can a rollout or rollback fail? Can it impact already running workloads?

In general, rollout / rollback should not fail since the feature needs to be explicitly set in the PVC.

###### What specific metrics should inform a rollback?

A metric `controller_modify_volume_errors_total` will indicate a problem with the feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or crashes of ...

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, msau42, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025
@carlory
Copy link
Member

carlory commented Jun 9, 2025

@sunnylovestiramisu Can you add the following content to our KEP? I found it in this PR. https://github.com/kubernetes/enhancements/pull/5333/files#diff-b665d199c610a17172a3409cff970858d9f4f51d01b9d5c59084e38ff6bdd235R846

I think it is good example

After promotion to GA, they are enabled by default, but can still be disabled. Disabling is allowed because it couldn't be
on-by-default during beta due to the dependency on the off-by-default API group and immediately turning it on by default with no fallback option could be too risky.

@sunnylovestiramisu sunnylovestiramisu force-pushed the updateVAC branch 2 times, most recently from 98846c8 to 0191c23 Compare June 9, 2025 16:47
@sunnylovestiramisu
Copy link
Contributor Author

@sunnylovestiramisu Can you add the following content to our KEP? I found it in this PR. https://github.com/kubernetes/enhancements/pull/5333/files#diff-b665d199c610a17172a3409cff970858d9f4f51d01b9d5c59084e38ff6bdd235R846

I think it is good example

After promotion to GA, they are enabled by default, but can still be disabled. Disabling is allowed because it couldn't be
on-by-default during beta due to the dependency on the off-by-default API group and immediately turning it on by default with no fallback option could be too risky.

Done, added to the flag combination part.

@xing-yang
Copy link
Contributor

Discussed with @msau42 about this #5024 (comment). @sunnylovestiramisu will check with sig-architecture to confirm if this is the recommended approach.

@sunnylovestiramisu
Copy link
Contributor Author

Discussed with @msau42 about this #5024 (comment). @sunnylovestiramisu will check with sig-architecture to confirm if this is the recommended approach.

@SergeyKanzhelev pointed us to a reference page: https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/5241-beta-featuregate-promotion-requirements#proposal

xing-yang
xing-yang reviewed Jun 9, 2025
View reviewed changes
keps/sig-storage/3751-volume-attributes-class/README.md Outdated
After promotion to GA, the feature is enabled by default but can still be disabled.
Disabling is allowed because it could not be enabled by default during beta due to its
dependency on the off-by-default API group. Immediately enabling it by default with no
fallback option could be too risky.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this reference page here? https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/5241-beta-featuregate-promotion-requirements#proposal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4bfb40a into kubernetes:master Jun 9, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@xing-yang xing-yang xing-yang left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@msau42 msau42 msau42 left review comments

@carlory carlory carlory left review comments

@AndrewSirenko AndrewSirenko AndrewSirenko left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@xing-yang xing-yang

@johnbelamaric johnbelamaric

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
9 participants
@sunnylovestiramisu @xing-yang @sftim @johnbelamaric @msau42 @k8s-ci-robot @carlory @gnufied @AndrewSirenko