Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KEP 3157 (watch-list) for milestone 1.33 #5047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update KEP 3157 (watch-list) for milestone 1.33 #5047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion keps/sig-api-machinery/3157-watch-list/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
#### Beta
- Metrics are added to the kube-apiserver (see the [monitoring-requirements](#monitoring-requirements) section for more details)
- Implement `SendInitialEvents` for `watch` requests in the etcd storage implementation
- The feature is enabled for kube-apiserver and kube-controller-manager
- The feature is enabled for kube-apiserver, kube-controller-manager and kubelet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively we could enable for the kube-scheduler or for both, i don't have a strong opinion.

- The generic feature gate mechanism is implemented in client-go.
It will be used to enable a new functionality for reflectors/informers.
- Implement a consistency check detector that will compare data received through a new watchlist request
Expand All @@ -755,6 +755,10 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
must properly set the kind and apiVersion fields.
These fields are important for the correct decoding of the objects.
See also: https://github.com/kubernetes/kubernetes/pull/126191
- Add watchlist support to the fake client so that starting an informer with a fake client works correctly.
- Extend the existing performance tests with a case that adds a large number of small objects.
The current perf test adds a small number of large objects.
The new variant will help catch potential regressions such as https://github.com/kubernetes/kubernetes/issues/129467

#### GA
- [Switch](https://github.com/kubernetes/kubernetes/blob/a07b1aaa5b39b351ec8586de800baa5715304a3f/staging/src/k8s.io/apiserver/pkg/storage/cacher/cacher.go#L416)
Expand Down