Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP 4815]Update the API design based on the discussion during implementation. #5211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[KEP 4815]Update the API design based on the discussion during implementation. #5211

wants to merge 2 commits into from

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Mar 18, 2025

  • Issue link:
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and Huang-Wei March 18, 2025 21:42
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 18, 2025
@cici37
Copy link
Contributor Author

cici37 commented Mar 18, 2025

/assign @johnbelamaric

johnbelamaric
johnbelamaric reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Noticed a few more things that are needed. I think this PR can wait until after code freeze though.

keps/sig-scheduling/4815-dra-partitionable-devices/README.md
@@ -967,8 +959,8 @@ devices:
int: 3
uuid:
string: GPU-662077db-fa3f-0d8f-9502-21ab0ef058a2
consumesCapacity:
- capacityPool: gpu-3-pool
consumesCounter:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consumesCounters (plural)

throughout the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it as consumesCounter to match what we have in implementation. The v1beta2 rename should be out of the scope of this KEP.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cici37
Once this PR has been reviewed and has the lgtm label, please ask for approval from johnbelamaric. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cici37
Copy link
Contributor Author

cici37 commented Mar 19, 2025

All comments have been addressed. :)

@johnbelamaric
Copy link
Member

All comments have been addressed. :)

Let's wait until kubernetes/kubernetes#130932 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric johnbelamaric left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@johnbelamaric johnbelamaric

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Scheduling
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cici37 @k8s-ci-robot @johnbelamaric