Skip to content

KEP-4322: Merge KEP-5339 into KEP-4322#6136

Open
mikeshng wants to merge 1 commit into
kubernetes:masterfrom
mikeshng:combine-KEP-5339-and-4332
Open

KEP-4322: Merge KEP-5339 into KEP-4322#6136
mikeshng wants to merge 1 commit into
kubernetes:masterfrom
mikeshng:combine-KEP-5339-and-4332

Conversation

@mikeshng

@mikeshng mikeshng commented Jun 1, 2026

Copy link
Copy Markdown
Member
  • One-line PR description: KEP-5339 (Plugin for Credentials in ClusterProfile) content has been moved into KEP-4322 (ClusterProfile API) since the base API and the credentials-related fields are expected to graduate together. KEP-5339 is marked as replaced.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2026
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 1, 2026
@mikeshng

mikeshng commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

/assign @kahirokunn @lauralorenz @skitt

kahirokunn
kahirokunn approved these changes Jun 2, 2026
View reviewed changes

@kahirokunn kahirokunn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉

kahirokunn
kahirokunn reviewed Jun 3, 2026
View reviewed changes
Comment thread keps/sig-multicluster/4322-cluster-inventory/README.md Outdated
-->

Because of its interaction with authentication and credentials, particular
attention in the credential provider plugin design must be paid to security:

@kahirokunn kahirokunn Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that Access Provider Plugins is the correct term instead of Credential Provider Plugins?

@mikeshng mikeshng Jun 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Updated!

@mikeshng
Merge KEP-5339 into KEP-4322
cecc1c2 
KEP-5339 (Plugin for Credentials in ClusterProfile) content has been moved into KEP-4322 (ClusterProfile API) since the base API and the credentials-related fields are expected to graduate together. KEP-5339 is marked as replaced.

Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng mikeshng force-pushed the combine-KEP-5339-and-4332 branch from 2bbadbf to cecc1c2 Compare June 4, 2026 00:23
@kahirokunn

kahirokunn commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@mikeshng Should we remove "Push Model via Credentials in Secret (Not Recommended)"?

Because there are already two plugins provided, the secret reader plugin and the kubeconfig secret reader plugin, which completely encapsulate the functionality of "Push Model via Credentials in Secret (Not Recommended)."

I believe this feature is no longer necessary.

The discussion in the following issue might be helpful:
kubernetes-sigs/cluster-inventory-api#18

@mikeshng

mikeshng commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

@kahirokunn yes, we should do that but under new PR. This PR should be focusing on merging the KEPs first. WDYT?

@kahirokunn

kahirokunn commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Let’s do that. 👍
Would it be alright if I created the new pull request?

@mikeshng

mikeshng commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

SGTM

@kahirokunn kahirokunn mentioned this pull request Jun 5, 2026
Open
4 tasks
@skitt

skitt commented Jun 16, 2026

Copy link
Copy Markdown
Member

/approve

Thanks!

@k8s-ci-robot

k8s-ci-robot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kahirokunn, mikeshng, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

1 more reviewer

@kahirokunn kahirokunn kahirokunn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skitt skitt

@lauralorenz lauralorenz

@kahirokunn kahirokunn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikeshng @kahirokunn @skitt @k8s-ci-robot @lauralorenz