WIP L3 NetLB experiment by TortillaZHawaii · Pull Request #2976 · kubernetes/ingress-gce

TortillaZHawaii · 2025-09-05T12:37:20Z

No description provided.

k8s-ci-robot · 2025-09-05T12:37:23Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

k8s-ci-robot · 2025-09-05T12:37:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TortillaZHawaii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [TortillaZHawaii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TortillaZHawaii · 2025-09-05T13:03:42Z

/lint

k8s-ci-robot

@TortillaZHawaii: 2 warnings.

Details

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-09-05T13:03:53Z

pkg/loadbalancers/l3/wants.go

+	"k8s.io/ingress-gce/pkg/flags"
+)
+
+const ExperimentAnnotation = "networking.gke.io/l3-experiment"


Golint comments: exported const ExperimentAnnotation should have comment or be unexported. More info.

k8s-ci-robot · 2025-09-05T13:03:53Z

pkg/loadbalancers/l3/wants.go

+
+const ExperimentAnnotation = "networking.gke.io/l3-experiment"
+
+func Wants(svc *corev1.Service) bool {


Golint comments: exported function Wants should have comment or be unexported. More info.

Copilot

Pull Request Overview

This pull request introduces experimental L3 NetLB support by adding logic to conditionally configure forwarding rules and backend services for L3 protocol when the service is annotated with the L3 experiment annotation.

Adds L3 experiment annotation detection and enabling flag
Modifies backend service protocol selection to support L3
Updates forwarding rule creation to use L3 protocol and all ports when in L3 mode

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/loadbalancers/l3/wants.go	New file implementing L3 experiment detection logic
pkg/flags/flags.go	Adds flag to enable L3 NetLB opt-in functionality
pkg/loadbalancers/l4netlb.go	Refactors protocol selection and forwarding rule annotation handling
pkg/loadbalancers/l4netlbipv6.go	Updates IPv6 firewall configuration for mixed protocol support
pkg/loadbalancers/forwarding_rules.go	Modifies IPv4 forwarding rule creation for L3 support
pkg/loadbalancers/forwarding_rules_ipv6.go	Modifies IPv6 forwarding rule creation for L3 support
pkg/forwardingrules/equal.go	Improves string comparison using EqualFold

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-05T13:04:01Z

pkg/loadbalancers/l4netlb.go

+	if protocol == "" {
+		protocol = "UDP"


The hardcoded default protocol 'UDP' should be defined as a constant or sourced from the same location as other protocol constants to maintain consistency and avoid magic strings.

Suggested change

if protocol == "" {

protocol = "UDP"

protocol = forwardingrules.ProtocolUDP

Copilot · 2025-09-05T13:04:01Z

pkg/loadbalancers/l4netlb.go

+
+	version := fr.IpVersion
+	if version == "" {
+		version = "IPV4"


The hardcoded default version 'IPV4' should be defined as a constant to avoid magic strings and improve maintainability.

TortillaZHawaii · 2025-09-05T13:43:59Z

/test-all

k8s-ci-robot · 2025-10-08T05:19:09Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2026-01-06T05:48:11Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2026-02-05T06:46:38Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2025

k8s-ci-robot requested review from aojea and sawsa307 September 5, 2025 12:37

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2025

TortillaZHawaii requested a review from Copilot September 5, 2025 13:03

k8s-ci-robot reviewed Sep 5, 2025

View reviewed changes

Copilot AI reviewed Sep 5, 2025

View reviewed changes

TortillaZHawaii force-pushed the l3-netlb-experiment branch from dbbc214 to 72a88d0 Compare September 5, 2025 13:42

WIP L3 NetLB experiment

b792843

TortillaZHawaii force-pushed the l3-netlb-experiment branch from 72a88d0 to b792843 Compare September 5, 2025 13:57

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2026

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2026


		const ExperimentAnnotation = "networking.gke.io/l3-experiment"

		func Wants(svc *corev1.Service) bool {

	if protocol == "" {
	protocol = "UDP"
	protocol = forwardingrules.ProtocolUDP

Conversation

TortillaZHawaii commented Sep 5, 2025

Uh oh!

k8s-ci-robot commented Sep 5, 2025

Uh oh!

k8s-ci-robot commented Sep 5, 2025

Uh oh!

TortillaZHawaii commented Sep 5, 2025

Uh oh!

k8s-ci-robot left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

TortillaZHawaii commented Sep 5, 2025

Uh oh!

k8s-ci-robot commented Oct 8, 2025

Uh oh!

k8s-triage-robot commented Jan 6, 2026

Uh oh!

k8s-triage-robot commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants