Skip to content

Fix edge case when cleaning up deny firewall rules on XPN without per…#3041

Open
TortillaZHawaii wants to merge 1 commit intokubernetes:masterfrom
TortillaZHawaii:deny-on-xpn
Open

Fix edge case when cleaning up deny firewall rules on XPN without per…#3041
TortillaZHawaii wants to merge 1 commit intokubernetes:masterfrom
TortillaZHawaii:deny-on-xpn

Conversation

@TortillaZHawaii
Copy link
Member

…missions

This is caused by not checking XPN related errors inside soft clean up function. Also adds flag gates to service deletion logic around deny firewalls.

Based on

existingFw, err := fa.GetFirewall(params.Name)
if err != nil && !utils.IsNotFoundError(err) {
return utils.ResourceResync, err
}
we don't need to check for XPN error when retrieving, so this might be unnecessary

/hold
/assign @mmamczur

…missions

This is caused by not checking XPN related errors inside soft clean up function. Also adds flag gates to service deletion logic around deny firewalls.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TortillaZHawaii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2026
@TortillaZHawaii
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants