Skip to content

feat(logging): enhance L4LBConfig and LoggingConfig with improved validation rules for optionalFields#3051

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
08volt:logging-fix-empty-custom
Feb 17, 2026
Merged

feat(logging): enhance L4LBConfig and LoggingConfig with improved validation rules for optionalFields#3051
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
08volt:logging-fix-empty-custom

Conversation

@08volt
Copy link
Member

@08volt 08volt commented Feb 16, 2026

Add cross validation for OptionalFields at api level.
Left double-check during controller reconciliation with comment.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 16, 2026
@08volt
Copy link
Member Author

08volt commented Feb 16, 2026

/retest

@08volt 08volt force-pushed the logging-fix-empty-custom branch from 0d3bb6a to 234c97d Compare February 17, 2026 09:05
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2026
@08volt 08volt force-pushed the logging-fix-empty-custom branch from 234c97d to 76aa3d3 Compare February 17, 2026 09:08
@TortillaZHawaii
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2026
@08volt
Copy link
Member Author

08volt commented Feb 17, 2026

/retest

@08volt 08volt force-pushed the logging-fix-empty-custom branch from 76aa3d3 to dc54bfb Compare February 17, 2026 09:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2026
@08volt 08volt force-pushed the logging-fix-empty-custom branch 4 times, most recently from 868e8e9 to a98cd19 Compare February 17, 2026 11:23
@08volt 08volt force-pushed the logging-fix-empty-custom branch from a98cd19 to 34f368c Compare February 17, 2026 12:54
@TortillaZHawaii
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 08volt, TortillaZHawaii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [08volt,TortillaZHawaii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f58d067 into kubernetes:master Feb 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants