clusters/aaa: minor cleanup #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
ameukam
reviewed
Aug 3, 2021
Comment on lines
27
to
32
| resource "google_storage_bucket" "scalability_tests_logs" { | ||
| project = data.google_project.project.project_id | ||
| name = local.scalability_tests_logs_bucket_name | ||
|
|
||
| uniform_bucket_level_access = true | ||
| } |
There was a problem hiding this comment.
@spiffxp Can you add a lifecycle policy of 90 days of retention as suggested here : #1310 (comment)? 🙏🏾
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved bucket creation for prowjobs into its own .tf file
rather than manually reformatting the resulting comments, I ran
terraform fmtwhich updated a few more files in here as wellEDIT: also snuck in a change to add 90d lifecycle deletion to the scalability logs bucket