Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a subscription to gs://kubernetes-ci-logs. #7370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a subscription to gs://kubernetes-ci-logs. #7370

wants to merge 1 commit into from
+23 −0

Conversation

michelle192837
Copy link
Contributor

@michelle192837 michelle192837 commented Oct 4, 2024 •
edited
Loading

There's an existing PubSub topic for GCS changes to gs://kubernetes-ci-logs (in k8s-infra-prow). Attempt to add a new subscription to this in kubernetes-public so Kettle can use updates from the new logs bucket.

(Note: I don't have permissions to run terraform here, so I haven't verified that these additions are valid.)

/hold

Don't submit until we verify this will do something with terraform plan

Ref kubernetes/test-infra#33381

@michelle192837
Add a subscription to gs://kubernetes-ci-logs.
30b8ae3 
There's an existing PubSub topic for GCS changes to
gs://kubernetes-ci-logs (in k8s-infra-prow). Attempt to add a new
subscription to this in kubernetes-public so Kettle can use updates from
the new logs bucket.

(Note: I don't have permissions to run terraform here, so I haven't
verified that these additions are valid.)
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michelle192837
Once this PR has been reviewed and has the lgtm label, please assign spiffxp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michelle192837 @k8s-ci-robot