-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Remove securityGroupOverride validation for NLB #17383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @h3poteto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
I think this is a feature so should not delay releases? That said it seems pretty safe (as it's only validation IIUC), so I don't mind if we backport it to (say) 1.32. |
fix #17207
NLBs did not support security groups in the past. However, AWS now supports specifying a security group for an NLB. When kops creates a new cluster with an NLB, it also creates a security group for it by default.
Therefore, I believe we can now allow
securityGroupOverride
for NLBs in kops as well.Please let me know if I'm overlooking anything or if there are any concerns with this approach.