Skip to content

Fix Netlify build failure from template syntax error and PATH issues in documentation #17767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 6 commits into from
Nov 23, 2025
+2 −3
Merged

Fix Netlify build failure from template syntax error and PATH issues in documentation #17767

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9e30f9
Initial plan
Copilot Nov 23, 2025
39ef818
Fix Netlify build by escaping Go template syntax in scaleway.md
Copilot Nov 23, 2025
b4035cd
Fix Netlify strict mode build by removing missing canal.md reference …
Copilot Nov 23, 2025
96ed151
Simplify exclude_docs syntax in mkdocs.yml
Copilot Nov 23, 2025
cf9e438
Fix mkdocs command not found in Netlify by using python -m mkdocs
Copilot Nov 23, 2025
f12bb70
Revert exclude_docs change from mkdocs.yml
Copilot Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ build-docs:
.PHONY: build-docs-netlify
build-docs-netlify:
pip install -r ${KOPS_ROOT}/images/mkdocs/requirements.txt
mkdocs build
python -m mkdocs build

#-----------------------------------------------------------
# development targets
Expand Down
2 changes: 1 addition & 1 deletion docs/getting_started/scaleway.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ for SERVER in "${TF_SERVERS[@]}"; do
# We remove the stale instance from the state
terraform state rm scaleway_instance_server.$SERVER
# We fetch its new ID
NEW_SERVER_ID=$(scw instance server list zone=$ZONE name=$SERVER -o template="{{ .ID }}")
NEW_SERVER_ID=$(scw instance server list zone=$ZONE name=$SERVER -o template="{% raw %}{{ .ID }}{% endraw %}")
if [ "$NEW_SERVER_ID" == "" ]; then
echo "could not find new ID of the server $SERVER"
fi
Expand Down
2 changes: 1 addition & 1 deletion mkdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ site_name: kOps - Kubernetes Operations
repo_name: 'kubernetes/kops'
repo_url: 'https://github.com/kubernetes/kops'
site_url: 'https://kops.sigs.k8s.io'
exclude_docs: README.md

@hakman hakman Nov 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot revert this change

Copilot AI Nov 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in f12bb70. The exclude_docs: README.md line has been removed from mkdocs.yml. The README.md warning still appears but mkdocs automatically handles it by excluding README.md in favor of index.md.

markdown_extensions:
- admonition
- codehilite
Expand Down Expand Up @@ -123,7 +124,6 @@ nav:
- CNI:
- AWS VPC: "networking/aws-vpc.md"
- Calico: "networking/calico.md"
- Canal: "networking/canal.md"
- Cilium: "networking/cilium.md"
- Flannel: "networking/flannel.md"
- Kube-Router: "networking/kube-router.md"
Expand Down