enable metrics server for scale tests

[upodroid]

The kubeup scale jobs used to run metrics-server, so we need to run it as well.

@serathius

[serathius]

But metrics server will not tolerate control-plain taint.

[upodroid]

I'll fix that in a separate PR today

[serathius]

Could we separate those efforts? No reason to mix metrics server with exec service.

[hakman]

/hold

[hakman]

@upodroid feel free to /unhold when ready.

[upodroid]

I have a better approach, metrics server pods needs to be deployed to tolerate control plane taints and bigger resource and I don't want to add that to kops. Instead, I implemented a kubetest1 flag called pre-test-cmd which behaves like the exec tester in kubetest2 so it should work much better. It also fixed up a few other kops jobs too

kubernetes-sigs/kubetest2#325

Once that's merged and shipped, we'll invoke a script that installs metrics-server to suit our use case and run any arbitrary commands before clusterloader2 starts

[hakman]

/approve cancel

[hakman]

/unapprove

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[upodroid]

This is ready to be merged

/test pull-kops-ec2-master-scale-performance-100

[serathius]

/lgtm

Having a addons node is huge improvement. Thanks!

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[upodroid]

/test pull-kops-ec2-master-scale-performance-100

[serathius]

Flake?

[k8s-ci-robot]

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kops-ec2-master-scale-performance-100	03da0fa	link	true	/test pull-kops-ec2-master-scale-performance-100

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.