Move VFS acls framework closer to VFS implementation code#17949
Move VFS acls framework closer to VFS implementation code#17949rramkumar1 wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
Hi @rramkumar1. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
910de02 to
ed7a8f1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
bd5eac6 to
d3d8ab6
Compare
d3d8ab6 to
b959541
Compare
This is a purely cosmetic change. The code for setting ACLs on VFS paths was in a separate section of the directory tree entirely from the code that implements the various VFS providers. I think it makes sense for all this code to be together (now at util/pkg/vfs/..)
There is also a separate question here of why generating ACLs needs to be done separately from the action that writes to the file if both those operations go hand-in-hand anyway. Will investigate if generating the ACL can be abstracted away from the code paths that write to file so that callers only need to worry about writing to file.
/assign @hakman