Skip to content

Move VFS acls framework closer to VFS implementation code#17949

Open
rramkumar1 wants to merge 1 commit intokubernetes:masterfrom
rramkumar1:move-vfs-acls-lib
Open

Move VFS acls framework closer to VFS implementation code#17949
rramkumar1 wants to merge 1 commit intokubernetes:masterfrom
rramkumar1:move-vfs-acls-lib

Conversation

@rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Feb 12, 2026

This is a purely cosmetic change. The code for setting ACLs on VFS paths was in a separate section of the directory tree entirely from the code that implements the various VFS providers. I think it makes sense for all this code to be together (now at util/pkg/vfs/..)

There is also a separate question here of why generating ACLs needs to be done separately from the action that writes to the file if both those operations go hand-in-hand anyway. Will investigate if generating the ACL can be abstracted away from the code paths that write to file so that callers only need to worry about writing to file.

/assign @hakman

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @rramkumar1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Feb 12, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rramkumar1 rramkumar1 force-pushed the move-vfs-acls-lib branch 4 times, most recently from bd5eac6 to d3d8ab6 Compare February 12, 2026 19:55
@rramkumar1 rramkumar1 changed the title Move VFS acls framework closer to VVFS implementation code Move VFS acls framework closer to VFS implementation code Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants