rework the markers to make kops markers behave the same as kubernetes markers#17975
rework the markers to make kops markers behave the same as kubernetes markers#17975upodroid wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
5448724 to
37e9694
Compare
37e9694 to
160ab21
Compare
|
@upodroid: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I'm trying to shield gs://k8s-staging-kops behind Fastly, and to do that, we need to change how the markers are created.
The marker can't contain the url; it can only contain the version. Therefore, the releases are pushed directly to the root of the bucket, and the markers live there. We will also remove the updown marker generators as we don't need them anymore.
This should allow this to work:
Finally, I aligned the version logic with kubernetes so no more hardcoding versions in Go.
I tested the cloudbuild changes, and you can see the job at https://console.cloud.google.com/cloud-build/builds;region=global/ca41cc0c-900d-4bbe-b5db-c93fb77437ad?organizationId=758905017065&project=k8s-infra-e2e-node-e2e-project.