Skip to content

rework the markers to make kops markers behave the same as kubernetes markers#17975

Open
upodroid wants to merge 1 commit intokubernetes:masterfrom
upodroid:redo-markers
Open

rework the markers to make kops markers behave the same as kubernetes markers#17975
upodroid wants to merge 1 commit intokubernetes:masterfrom
upodroid:redo-markers

Conversation

@upodroid
Copy link
Member

@upodroid upodroid commented Feb 17, 2026

I'm trying to shield gs://k8s-staging-kops behind Fastly, and to do that, we need to change how the markers are created.

 mahamed  Mac  ~  1  $  curl https://dl.k8s.io/ci/latest.txt
v1.36.0-alpha.1.232+23fc0bff62ff36
BASE_URL = https://dl.k8s.io/ci/v1.36.0-alpha.1.232+23fc0bff62ff36

 mahamed  Mac  ~  1  $  curl https://storage.googleapis.com/k8s-release-dev/ci/latest.txt
v1.36.0-alpha.1.232+23fc0bff62ff36
BASE_URL=https://storage.googleapis.com/k8s-release-dev/ci/v1.36.0-alpha.1.232+23fc0bff62ff36
 mahamed  Mac  ~  1  $  curl https://storage.googleapis.com/k8s-staging-kops/kops/releases/markers/master/latest-ci.txt
https://storage.googleapis.com/k8s-staging-kops/kops/releases/1.35.0-beta.2+v1.35.0-beta.1-26-g7b714f7e57
BASE_URL=https://storage.googleapis.com/k8s-staging-kops/kops/releases/1.35.0-beta.2+v1.35.0-beta.1-26-g7b714f7e57

# Problematic
 mahamed  Mac  ~  1  $  curl https://dl.k8s.io/kops/releases/markers/master/latest-ci.txt
https://storage.googleapis.com/k8s-staging-kops/kops/releases/1.35.0-beta.2+v1.35.0-beta.1-26-g7b714f7e57
BASE_URL=https://storage.googleapis.com/k8s-staging-kops/kops/releases/1.35.0-beta.2+v1.35.0-beta.1-26-g7b714f7e57

The marker can't contain the url; it can only contain the version. Therefore, the releases are pushed directly to the root of the bucket, and the markers live there. We will also remove the updown marker generators as we don't need them anymore.

This should allow this to work:

--kops-version-marker=https://dl.k8s.io/ci/kops/latest.txt => v1.35.0-beta.1-26-g7b714f7e57 
KOPS_BASE_URL=
https://dl.k8s.io/kops/v1.35.0-beta.1-26-g7b714f7e57

--kops-version-marker=https://dl.k8s.io/ci/kops/latest-1.34.txt => v1.34.1-26-g7b714f7e57 
KOPS_BASE_URL=https://dl.k8s.io/kops/v1.34.1-26-g7b714f7e57

Finally, I aligned the version logic with kubernetes so no more hardcoding versions in Go.

I tested the cloudbuild changes, and you can see the job at https://console.cloud.google.com/cloud-build/builds;region=global/ca41cc0c-900d-4bbe-b5db-c93fb77437ad?organizationId=758905017065&project=k8s-infra-e2e-node-e2e-project.

 mahamed  Mac  ~  1  ERROR  $  gsutil ls gs://k8s-infra-e2e-node-e2e-project
gs://k8s-infra-e2e-node-e2e-project/latest.txt
gs://k8s-infra-e2e-node-e2e-project/v1.35.0-alpha.1-241-g4bfe8a5cb5-dirty/

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2026
@upodroid
Copy link
Member Author

/cc @hakman @justinsb @rifelpet

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 17, 2026

@upodroid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-test 160ab21 link true /test pull-kops-test
pull-kops-kubernetes-e2e-ubuntu-gce-build 160ab21 link false /test pull-kops-kubernetes-e2e-ubuntu-gce-build
pull-kops-e2e-k8s-aws-calico 160ab21 link true /test pull-kops-e2e-k8s-aws-calico
pull-kops-e2e-k8s-aws-amazonvpc 160ab21 link true /test pull-kops-e2e-k8s-aws-amazonvpc

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants