Conversation
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test pull-kops-e2e-aws-load-balancer-controller |
3 similar comments
|
/test pull-kops-e2e-aws-load-balancer-controller |
|
/test pull-kops-e2e-aws-load-balancer-controller |
|
/test pull-kops-e2e-aws-load-balancer-controller |
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
|
/test pull-kops-e2e-aws-load-balancer-controller |
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
|
/test pull-kops-e2e-aws-load-balancer-controller |
1 similar comment
|
/test pull-kops-e2e-aws-load-balancer-controller |
|
/lgtm |
|
/test pull-kops-e2e-aws-load-balancer-controller |
1 similar comment
|
/test pull-kops-e2e-aws-load-balancer-controller |
|
/test pull-kops-e2e-k8s-gce-cilium |
|
/test pull-kops-e2e-aws-load-balancer-controller |
|
One of the tests is consistently failing because we need to update the IAM policy to use the Null condition for CreateTargetGroup like in the example |
|
@rifelpet Just wanted to see that the clusters validates consistently and most tests run. |
|
None of kops' addons in kube-system need AWS load balancers. I suppose users might be installing their own applications to kube-system that might need LBs? I'm not sure how much we guarantee around that or if users would need a way to override that behavior. |
|
@hakman: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test pull-kops-e2e-k8s-aws-amazonvpc |
|
@hakman should we merge this as-is and fix the tests in a followup? |
/cc @rifelpet @justinsb