Skip to content

aws: Update LBC to v2.17.1#18003

Open
hakman wants to merge 5 commits intokubernetes:masterfrom
hakman:bypass-lbc
Open

aws: Update LBC to v2.17.1#18003
hakman wants to merge 5 commits intokubernetes:masterfrom
hakman:bypass-lbc

Conversation

@hakman
Copy link
Member

@hakman hakman commented Feb 22, 2026

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 22, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member Author

hakman commented Feb 22, 2026

/test pull-kops-e2e-aws-load-balancer-controller

3 similar comments
@hakman
Copy link
Member Author

hakman commented Feb 22, 2026

/test pull-kops-e2e-aws-load-balancer-controller

@hakman
Copy link
Member Author

hakman commented Feb 22, 2026

/test pull-kops-e2e-aws-load-balancer-controller

@hakman
Copy link
Member Author

hakman commented Feb 22, 2026

/test pull-kops-e2e-aws-load-balancer-controller

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
Copy link
Member Author

hakman commented Feb 22, 2026

/test pull-kops-e2e-aws-load-balancer-controller

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
Copy link
Member Author

hakman commented Feb 22, 2026

/test pull-kops-e2e-aws-load-balancer-controller

1 similar comment
@hakman
Copy link
Member Author

hakman commented Feb 22, 2026

/test pull-kops-e2e-aws-load-balancer-controller

@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2026
@hakman
Copy link
Member Author

hakman commented Feb 23, 2026

/test pull-kops-e2e-aws-load-balancer-controller

1 similar comment
@hakman
Copy link
Member Author

hakman commented Feb 23, 2026

/test pull-kops-e2e-aws-load-balancer-controller

@hakman
Copy link
Member Author

hakman commented Feb 23, 2026

/test pull-kops-e2e-k8s-gce-cilium

@hakman
Copy link
Member Author

hakman commented Feb 23, 2026

/test pull-kops-e2e-aws-load-balancer-controller

@rifelpet
Copy link
Member

One of the tests is consistently failing because we need to update the IAM policy to use the Null condition for CreateTargetGroup like in the example

https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/docs/install/iam_policy.json

@hakman
Copy link
Member Author

hakman commented Feb 23, 2026

@rifelpet Just wanted to see that the clusters validates consistently and most tests run.
I am thinking it may be better to exclude the kube-system namespace for LB webhooks. WDYT?

@rifelpet
Copy link
Member

None of kops' addons in kube-system need AWS load balancers. I suppose users might be installing their own applications to kube-system that might need LBs? I'm not sure how much we guarantee around that or if users would need a way to override that behavior.

@k8s-ci-robot
Copy link
Contributor

@hakman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons 13a1872 link false /test pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons
pull-kops-e2e-aws-load-balancer-controller 13a1872 link true /test pull-kops-e2e-aws-load-balancer-controller

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member Author

hakman commented Mar 7, 2026

/test pull-kops-e2e-k8s-aws-amazonvpc

@rifelpet
Copy link
Member

rifelpet commented Mar 7, 2026

@hakman should we merge this as-is and fix the tests in a followup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants