Skip to content

fix: allow AWS subnet ID without zone in cluster manifest#18031

Open
VedantMadane wants to merge 1 commit intokubernetes:masterfrom
VedantMadane:fix/allow-subnet-id-without-zone
Open

fix: allow AWS subnet ID without zone in cluster manifest#18031
VedantMadane wants to merge 1 commit intokubernetes:masterfrom
VedantMadane:fix/allow-subnet-id-without-zone

Conversation

@VedantMadane
Copy link

Fixes #14710. This PR allows specifying a subnet by ID without requiring an accompanying zone in the cluster manifest. kOps is already capable of resolving the zone from AWS if the ID is known.

This PR relaxes the requirement that all subnets must have a zone specified. If a subnet ID is provided, kops can resolve the zone from AWS during the build process.

This fixes an issue where kops would fail validation if spec.subnets[*].zone was omitted even when spec.subnets[*].id was present.
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hakman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from hakman March 2, 2026 08:37
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Mar 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus March 2, 2026 08:37
@k8s-ci-robot
Copy link
Contributor

Welcome @VedantMadane!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 2, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @VedantMadane. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/provider/aws Issues or PRs related to aws provider cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS: Cluster requires designating subnets by both ID and containing AZ

2 participants