fix: allow AWS subnet ID without zone in cluster manifest#18031
fix: allow AWS subnet ID without zone in cluster manifest#18031VedantMadane wants to merge 1 commit intokubernetes:masterfrom
Conversation
This PR relaxes the requirement that all subnets must have a zone specified. If a subnet ID is provided, kops can resolve the zone from AWS during the build process. This fixes an issue where kops would fail validation if spec.subnets[*].zone was omitted even when spec.subnets[*].id was present.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @VedantMadane! |
|
Hi @VedantMadane. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #14710. This PR allows specifying a subnet by ID without requiring an accompanying zone in the cluster manifest. kOps is already capable of resolving the zone from AWS if the ID is known.