Restore metrics-server kubelet preferred address types to upstream defaults

[nickdallavalentina]

This change updates the metrics-server addon configuration to use the upstream/default kubelet preferred address types instead of Hostname.

Before:

--kubelet-preferred-address-types=Hostname

After:

--kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname

We observed intermittent metrics-server scrape failures like:

Failed to scrape node, timeout to access kubelet err="Get "https://<node>.<REGION>.compute.internal:10250/metrics/resource": context deadline exceeded node="node-ID" timeout="10s"

I think using Hostname only is more fragile in environments where hostname resolution or the DNS/network path is intermittently slower than direct node IP access. Restoring the upstream/default order allows metrics-server to prefer InternalIP first, which is generally the most direct and reliable path for kubelet scraping. This also aligns our addon behavior with the upstream metrics-server manifests.

I'm not sure why the default behavior was changed. As you likely have more context around the reason for this modification, I'll leave the decision on whether to keep or change to you

Expected impact

This change should reduce intermittent kubelet scrape failures from metrics-server

Reference
metrics-server README / requirements: https://github.com/kubernetes-sigs/metrics-server?tab=readme-ov-file#requirements

[linux-foundation-easycla]

• ❌ - login: @ndallavalentina / name: Nicolo Dalla Valentina . The commit (4f57897) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Welcome @nickdallavalentina!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @nickdallavalentina. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hakman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment