azure: drop unused UsesPrivateDNS clause from API LB#18252
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Apr 26, 2026
Merged
azure: drop unused UsesPrivateDNS clause from API LB#18252k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
The Azure model has no DNSTypePrivate handling, so this branch never fires. Setting topology.dns=Private on Azure does not wire up a private DNS zone the way it does on AWS via Route53. Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
k8s-ci-robot
added
area/provider/azure
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
@hakman should we update api validation to prevent users from creating cluster objects in azure with dns=private ? |
Member
Author
yep, will send a PR for dns topology validation later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Azure model has no DNSTypePrivate handling, so this branch never fires. Setting topology.dns=Private on Azure does not wire up a private DNS zone the way it does on AWS via Route53.
/cc @rifelpet @ameukam