Skip to content

Automated cherry pick of #18251: aws: skip node S3 permissions when kops-controller serves node config#18253

Merged
k8s-ci-robot merged 2 commits intorelease-1.35from
automated-cherry-pick-of-#18251-upstream-release-1.35
Apr 26, 2026
Merged

Automated cherry pick of #18251: aws: skip node S3 permissions when kops-controller serves node config#18253
k8s-ci-robot merged 2 commits intorelease-1.35from
automated-cherry-pick-of-#18251-upstream-release-1.35

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Apr 26, 2026

Cherry pick of #18251 on release-1.35.

#18251: aws: skip node S3 permissions when kops-controller serves node config

For details on the cherry pick process, see the cherry pick requests page.

NONE

Generated by Claude Code

hakman added 2 commits April 26, 2026 14:33
Nodes only needed S3 read access to fetch their nodeup config from the
state store. When kops-controller is used for node config, nodes obtain
it from kops-controller instead, so the S3 grants are unnecessary.

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Apr 26, 2026
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 26, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2026
@k8s-ci-robot k8s-ci-robot merged commit 8c869e6 into release-1.35 Apr 26, 2026
26 checks passed
@k8s-ci-robot k8s-ci-robot deleted the automated-cherry-pick-of-#18251-upstream-release-1.35 branch April 26, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants