protokube: drop unused flags, fields, and methods and cleanup#18293
Merged
Conversation
Removes dead code that was unused, no behavior change:
- main.go: --remove-dns-names, --dns-update-interval, --zone,
--dns-internal-suffix, --cluster-id (parsed, never read);
also RootFS package var and KubeBoot.InternalDNSSuffix
- {GCE,OpenStack}CloudProvider: unused Project() method
- nodeup ProtokubeFlags: matching ClusterID, DNSInternalSuffix,
Zone fields and their populators.
Convert struct fields that were only used for construction-time validation/logging into local vars, and drop a redundant interface: - AWS: drop zone, deviceMap; imdsClient becomes a local - GCE: drop compute, project, zone, region, clusterName (only discovery and instanceName are read post-construction) - OpenStack: drop storageZone - DO: drop region, dropletID and the now-orphaned getMetadataRegion / getMetadataDropletID helpers and constants - Azure: replace the local 4-method client interface with the concrete *gossipazure.Client; the interface served only as a compile-time assertion with no test mocks
The flag was always set true by nodeup and protokube already gated the label-bootstrap call on k.Master. Remove the flag, the ProtokubeFlags / KubeBoot fields, and the inner gate; rely on k.Master alone.
The local TokenSource type just reimplemented what golang.org/x/oauth2 already provides.
k8s-ci-robot
added
area/nodeup
area/provider/digitalocean
Member
Author
|
/retest |
rifelpet
approved these changes
May 9, 2026
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @rifelpet
Assisted by Claude Opus