dns-controller: default Provider when ExternalDNS is partially set#18301
dns-controller: default Provider when ExternalDNS is partially set#18301hakman wants to merge 1 commit into
Conversation
The defaulter at populate_cluster_spec.go only sets Provider=dns-controller when Spec.ExternalDNS is nil. After #18298 added PriorityClassName, a user (or `--override=spec.externalDns.priorityClassName=`) can leave ExternalDNS non-nil with Provider="", which silently drops the dns-controller addon from bootstrap-channel.yaml. Default Provider to dns-controller whenever it is empty, regardless of whether ExternalDNS itself is nil.
|
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: no
|
/close |
|
@hakman: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@hakman: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/close |
|
@hakman: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
The defaulter at populate_cluster_spec.go only sets Provider=dns-controller
when Spec.ExternalDNS is nil. After #18298 added PriorityClassName, a user
(or
--override=spec.externalDns.priorityClassName=) can leave ExternalDNSnon-nil with Provider="", which silently drops the dns-controller addon
from bootstrap-channel.yaml.
Default Provider to dns-controller whenever it is empty, regardless of
whether ExternalDNS itself is nil.