dns-controller: default Provider when ExternalDNS is partially set#18302
Merged
Conversation
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
cncf-cla: yes
Member
Author
|
/approve |
k8s-ci-robot
added
the
approved
Member
Author
rifelpet
approved these changes
May 10, 2026
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
May 10, 2026
…8302-upstream-release-1.34 Automated cherry pick of #18302: dns-controller: default Provider when ExternalDNS is partially set
k8s-ci-robot
added a commit
that referenced
this pull request
May 10, 2026
…8302-upstream-release-1.35 Automated cherry pick of #18302: dns-controller: default Provider when ExternalDNS is partially set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defaulter at
populate_cluster_spec.goonly setsProvider=dns-controllerwhenSpec.ExternalDNSis nil. After #18298 addedPriorityClassName, a user (or--override=spec.externalDns.priorityClassName=) can leaveExternalDNSnon-nil withProvider="", which silently drops the dns-controller addon frombootstrap-channel.yaml.In gossip clusters this strands workers: nothing publishes the
kops-controller.internal.<cluster>A record into the mesh, nodeup'sBootstrapClientlookup fails for the full timeout, and no node ever joins. First observed inpull-kops-aws-upgrade-gossipafter release-1.35 picked up the cherry-pick of #18298 — see build 2053420008796590080.Default
Providertodns-controllerwhenever it is empty, regardless of whetherExternalDNSitself is nil.Generated by Claude Code