feat(service): add kube_service_ports metric #2607
Conversation
|
|
k8s-ci-robot
added
cncf-cla: no
k8s-ci-robot
added
the
size/M
Signed-off-by: nahuel11500 <[email protected]>
nahuel11500
force-pushed
the
feat/add-kube-service-adress-metric
branch
from
a793b16 to
37e3690
Compare
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maxime1907, nahuel11500 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hello, any thought on this ? @mrueg @dgrisonnet Thank you |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
Hello, sorry to bother, any update on this ? @dgrisonnet Thank you |
| "", | ||
| wrapSvcFunc(func(e *v1.Service) *metric.Family { | ||
| ms := []*metric.Metric{} | ||
| labelKeys := []string{"port_protocol", "port_number", "port_name", "port_target", "port_node_number", "port_app_protocol"} |
There was a problem hiding this comment.
It has the cardinality issue.
Also, could you share what's the use case of this metric? Which alert will be added for this metric?
There was a problem hiding this comment.
Hello,
Thanks for your answer.
For our use case, we want to implement a dashboard that can show the different ports available on a service. And then connect more easily on them with Telepresence.
Regarding the cardinality issue, while we understand the concern, we believe it should be manageable.
What this PR does / why we need it:
Adds a simple metric kube_service_ports so that we can get details about the ports exposed by services.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
increases