-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add start and termination timestamps for init containers #2638
base: main
Are you sure you want to change the base?
feat: add start and termination timestamps for init containers #2638
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: drolando The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @drolando! |
What this PR does / why we need it:
The new Sidecar Containers introduced in k8s 1.28 implement sidecars as init containers: https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers .
I wanted to monitor when each native sidecar starts and ends, however kube-state-metrics only emits those metrics for normal containers.
Given that these are new metrics I've set them as
ALPHA
, let me know if you don't agreeHow does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
The cardinality increases since these metrics will be emitted also for init containers.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2627