-
Notifications
You must be signed in to change notification settings - Fork 42.1k
featuregate: ensure deterministic ordering in SetFeatureGatesDuringTest #136019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
featuregate: ensure deterministic ordering in SetFeatureGatesDuringTest #136019
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @itzPranshul. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itzPranshul The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
needs a test case too no? |
7975024 to
4f00775
Compare
|
Done. I have added a regression test, PTAL |
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
SetFeatureGatesDuringTest currently iterates over a map of feature overrides. Since Go map iteration is randomized, the order of application is non-deterministic. This causes flakiness when broad gates (e.g., AllBeta) and specific features are set in the same map, as the broad gate may randomly overwrite specific settings.
This PR sorts feature keys alphabetically before iteration to ensure a stable, predictable test state.
Which issue(s) this PR is related to:
fixes a part of #134009