Skip to content

Fix 130069 fix context todo kubelet cm - part 1#138969

Open
kAvEh-- wants to merge 7 commits into
kubernetes:masterfrom
kAvEh--:fix-130069-fix-context-todo-kubelet-cm
Open

Fix 130069 fix context todo kubelet cm - part 1#138969
kAvEh-- wants to merge 7 commits into
kubernetes:masterfrom
kAvEh--:fix-130069-fix-context-todo-kubelet-cm

Conversation

@kAvEh--
Copy link
Copy Markdown
Contributor

@kAvEh-- kAvEh-- commented May 11, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR is the first part of replacing the appropriate context with the context.TODO() or context.Background() in the ./pkg/kubelet/cm/.
I break it down into multiple parts to keep PRs small and readable.

Which issue(s) this PR is related to:

Part of #130069

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels May 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @kAvEh--. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 11, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 11, 2026
@k8s-ci-robot k8s-ci-robot requested review from klueska and krmayankk May 11, 2026 15:23
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kAvEh--
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kAvEh--
Copy link
Copy Markdown
Contributor Author

kAvEh-- commented May 11, 2026

cc: @bart0sh

@kAvEh--
Copy link
Copy Markdown
Contributor Author

kAvEh-- commented May 11, 2026

@bart0sh A question about the next parts of the changes: I found some places where context was passed to functions, and the only usage of that context is to define a logger from it. Shall I refactor those to pass the logger, or keep the current implementation and use context? for example here
If I want to do the replacement, there are many places to change, so the PR related to that change could be relatively big, but I see no complexity for that, just a replacement of the logger with context in many places.

@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented May 12, 2026

@bart0sh A question about the next parts of the changes: I found some places where context was passed to functions, and the only usage of that context is to define a logger from it. Shall I refactor those to pass the logger, or keep the current implementation and use context? for example here If I want to do the replacement, there are many places to change, so the PR related to that change could be relatively big, but I see no complexity for that, just a replacement of the logger with context in many places.

I'd suggest to concentrate on removing context.TODO and context.Background. Refactoring can be done separately.

@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented May 12, 2026

/ok-to-test

@kAvEh-- please, squash your commits into one, thanks!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2026
@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented May 12, 2026

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 12, 2026
@bart0sh bart0sh moved this from Triage to Waiting on Author in SIG Node: code and documentation PRs May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@kAvEh--: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd ea27010 link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-typecheck ea27010 link true /test pull-kubernetes-typecheck
pull-kubernetes-e2e-kind ea27010 link true /test pull-kubernetes-e2e-kind
pull-kubernetes-conformance-kind-ga-only-parallel ea27010 link true /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-cmd ea27010 link true /test pull-kubernetes-cmd
pull-kubernetes-e2e-gce ea27010 link true /test pull-kubernetes-e2e-gce
pull-kubernetes-linter-hints ea27010 link false /test pull-kubernetes-linter-hints
pull-kubernetes-unit ea27010 link true /test pull-kubernetes-unit
pull-kubernetes-verify ea27010 link true /test pull-kubernetes-verify
pull-kubernetes-unit-windows-master ea27010 link false /test pull-kubernetes-unit-windows-master
pull-kubernetes-integration ea27010 link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants