Fix 130069 fix context todo kubelet cm - part 1#138969
Conversation
|
Adding label DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @kAvEh--. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kAvEh-- The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
cc: @bart0sh |
|
@bart0sh A question about the next parts of the changes: I found some places where context was passed to functions, and the only usage of that context is to define a logger from it. Shall I refactor those to pass the logger, or keep the current implementation and use context? for example here |
I'd suggest to concentrate on removing context.TODO and context.Background. Refactoring can be done separately. |
|
/ok-to-test @kAvEh-- please, squash your commits into one, thanks! |
|
/triage accepted |
|
@kAvEh--: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR is the first part of replacing the appropriate context with the
context.TODO()orcontext.Background()in the./pkg/kubelet/cm/.I break it down into multiple parts to keep PRs small and readable.
Which issue(s) this PR is related to:
Part of #130069
Special notes for your reviewer:
Does this PR introduce a user-facing change?