Skip to content

Improve performance characteristic of selinux metric emission#138981

Open
gnufied wants to merge 1 commit into
kubernetes:masterfrom
gnufied:implement-optimized-selinux-metric-emission
Open

Improve performance characteristic of selinux metric emission#138981
gnufied wants to merge 1 commit into
kubernetes:masterfrom
gnufied:implement-optimized-selinux-metric-emission

Conversation

@gnufied
Copy link
Copy Markdown
Member

@gnufied gnufied commented May 12, 2026 •
edited
Loading

Avoid costly comparisons during selinux metric emission.

Avoid costly comparisons during selinux metric emission.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2026
@k8s-ci-robot k8s-ci-robot requested a review from humblec May 12, 2026 02:02
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang May 12, 2026 02:02
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 12, 2026

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 12, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps May 12, 2026
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 12, 2026
@gnufied
Copy link
Copy Markdown
Member Author

gnufied commented May 12, 2026

/sig storage

@gnufied
Copy link
Copy Markdown
Member Author

gnufied commented May 12, 2026

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 12, 2026
jsafrane
jsafrane reviewed May 12, 2026
View reviewed changes
Comment thread pkg/controller/volume/selinuxwarning/cache/volumecache.go
Comment on lines +318 to +319
// GetConflicts returns the current set of active conflicts (both directions, symmetric pairs).
func (c *volumeCache) GetConflicts(logger klog.Logger) []Conflict {
Copy link
Copy Markdown
Member

@jsafrane jsafrane May 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this change relate to "costly comparisons during selinux metric emission"?

Copy link
Copy Markdown
Member Author

@gnufied gnufied May 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I thought it is pretty obvious. GetConflicts simply returns only cached conflicts. No comparisons, no iterating through list of pods and volumes. We do trade some memory usage for improved performance in metric collection path.

@jsafrane
Copy link
Copy Markdown
Member

jsafrane commented May 12, 2026

/test help

@jsafrane
Copy link
Copy Markdown
Member

jsafrane commented May 12, 2026

/test pull-kubernetes-e2e-gce-storage-selinux

@gnufied
Copy link
Copy Markdown
Member Author

gnufied commented May 12, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane jsafrane left review comments

@humblec humblec Awaiting requested review from humblec

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Apps
Status: Needs Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gnufied @k8s-ci-robot @jsafrane