site: kvm2: Remove old part about needing to reboot by illume · Pull Request #21020 · kubernetes/minikube

illume · 2025-07-03T06:18:37Z

This note in the kvm2 driver docs about possibly needing to reboot I think is not true anymore.

There is no linked issue
Can't find any issues mentioning this issue
It's from 2019
I can't reproduce on Ubuntu 24.04, and others tried on Ubuntu 22.04, Debian testing and Gentoo

k8s-ci-robot · 2025-07-03T06:18:47Z

Welcome @illume!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-07-03T06:18:48Z

Hi @illume. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

minikube-bot · 2025-07-03T06:21:02Z

Can one of the admins verify this patch?

nirs

Looks good

nirs · 2025-07-05T18:17:43Z

 * `Machine didn't return an IP after 120 seconds` when firewall prevents VM network access [#3566](https://github.com/kubernetes/minikube/issues/3566)
 * `unable to set user and group to '65534:992` when `dynamic ownership = 1` in `qemu.conf` [#4467](https://github.com/kubernetes/minikube/issues/4467)
 * KVM VM's cannot be used simultaneously with VirtualBox  [#4913](https://github.com/kubernetes/minikube/issues/4913)
-* On some distributions, libvirt bridge networking may fail until the host reboots


I'm working with libvirt since 2013 and I never seen such issue. Maybe the issue is creating the network without presisting it. This should not happen if you follow the libvirt network configuration docs.

Minikube had a bug before 1.34 when it was deleting the libvirt network. This could result in missing network after you delete a cluster.

Deleting this looks good since we don't have any evidence and it may not be relevant for many years.

This was added in #4989 - there was no discussion on this item.

rata · 2025-07-16T15:37:03Z

I can confirm I didn't need to restart on debian nor ubuntu. Anything else to move forward with this?

k8s-triage-robot · 2025-10-14T15:54:46Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

rata · 2025-10-27T14:14:10Z

/remove-lifecycle stale

rata · 2025-10-27T14:14:24Z

I believe this is still needed

k8s-triage-robot · 2026-01-25T14:38:40Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

illume · 2026-01-29T17:20:33Z

@nirs @medyagh please review?

k8s-ci-robot · 2026-01-29T17:29:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: illume, nirs
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2026-02-28T17:48:38Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2026-03-30T18:10:55Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2026-03-30T18:11:01Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rata · 2026-03-31T09:11:08Z

/reopen

This had one approval already and it should still apply, IMHO

k8s-ci-robot · 2026-03-31T09:11:16Z

@rata: Reopened this PR.

Details

In response to this:

/reopen

This had one approval already and it should still apply, IMHO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

site: kvm2: Remove old part about needing to reboot

399db6a

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2025

k8s-ci-robot requested review from ComradeProgrammer and medyagh July 3, 2025 06:18

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2025

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2025

illume mentioned this pull request Jul 3, 2025

minikube: Improve cluster creation UX on Linux headlamp-k8s/plugins#282

Open

nirs reviewed Jul 5, 2025

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2026

nirs approved these changes Jan 29, 2026

View reviewed changes

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 28, 2026

k8s-ci-robot closed this Mar 30, 2026

k8s-ci-robot reopened this Mar 31, 2026

Conversation

illume commented Jul 3, 2025

Uh oh!

k8s-ci-robot commented Jul 3, 2025

Uh oh!

k8s-ci-robot commented Jul 3, 2025

Uh oh!

minikube-bot commented Jul 3, 2025

Uh oh!

nirs left a comment

Choose a reason for hiding this comment

Uh oh!

nirs Jul 5, 2025

Choose a reason for hiding this comment

Uh oh!

nirs Jul 5, 2025

Choose a reason for hiding this comment

Uh oh!

rata commented Jul 16, 2025

Uh oh!

k8s-triage-robot commented Oct 14, 2025

Uh oh!

rata commented Oct 27, 2025

Uh oh!

rata commented Oct 27, 2025

Uh oh!

k8s-triage-robot commented Jan 25, 2026

Uh oh!

illume commented Jan 29, 2026

Uh oh!

k8s-ci-robot commented Jan 29, 2026

Uh oh!

k8s-triage-robot commented Feb 28, 2026

Uh oh!

k8s-triage-robot commented Mar 30, 2026

Uh oh!

k8s-ci-robot commented Mar 30, 2026

Uh oh!

rata commented Mar 31, 2026

Uh oh!

k8s-ci-robot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants