Add initial image commands to smoke test (partial implementation) by henry3260 · Pull Request #21770 · kubernetes/minikube

henry3260 · 2025-10-18T17:15:58Z

Currently, it adds partial support for image-related smoke tests.
The following commands are implemented so far:

minikube image load pause.tar
minikube image build
minikube image ls
minikube image pull registry.k8s.io/pause
minikube image rm
minikube image save
minikube image tag

These commands can run in GitHub runners and do not require Kubernetes.

Should we include the image push operation in the smoke test, even though we can't truly validate its success?

k8s-ci-robot · 2025-10-18T17:16:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henry3260
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-10-18T17:16:08Z

Hi @henry3260. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

minikube-bot · 2025-10-18T17:21:03Z

Can one of the admins verify this patch?

nirs

This tests do not have any validations, so they will pass even if the command is broken, but they are very simple.

Another issue is that we cannot run these smoke test locally. We have image tests in the functional test suite that we could run there but this is much more work, so adding these trivial tests seems like a good idea if they are really trivial.

nirs · 2025-10-18T21:24:57Z

+          ./out/minikube image load docker.io/library/alpine ${{ env.LOG_ARGS }}
+      - name: minikube image build
+        run: |
+          ./out/minikube image build -t test-image . ${{ env.LOG_ARGS }}


image build needs a Containerfile. You can create one in this test.

Can we just use the Dockerfile located in test/integration/testdata/docker-env?

nirs · 2025-10-18T21:26:55Z

        run: |
-          ./out/minikube image build -t test-image . ${{ env.LOG_ARGS }}
-
+          ./out/minikube image build -t test-image ./out/testdata/docker-env ${{ env.LOG_ARGS }}


All the changes here belongs to previous commit, please squash.

nirs · 2025-10-18T21:28:13Z

              ${{ env.LOG_ARGS }}
+      - name: Copy testdata for image build
+        run: |
+          echo ">>> Copying testdata to ./out"


This log does not add any value, and it hides the actual command if the step command is folded. Please remove it.

medyagh · 2025-10-20T17:45:58Z

+          cp -r test/integration/testdata ./out
+      - name: minikube image load
+        run: |
+          ./out/minikube image load docker.io/library/alpine ${{ env.LOG_ARGS }}


lets use an image in github or anywhere else to avoid rate limit

you can use the gcr image for pause

you can use the gcr image for pause

Can I continue using Alpine in the image build?

k8s-ci-robot · 2025-12-22T14:18:26Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2026-03-22T14:36:21Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2026-04-21T15:06:36Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2025

k8s-ci-robot requested review from medyagh and nirs October 18, 2025 17:16

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2025

nirs reviewed Oct 18, 2025

View reviewed changes

medyagh reviewed Oct 20, 2025

View reviewed changes

henry3260 force-pushed the smoke_test branch 3 times, most recently from a54fa06 to f491b1a Compare October 21, 2025 06:52

henry3260 requested review from medyagh and nirs October 21, 2025 07:04

Add image operations in smoke test

2cb7efa

henry3260 force-pushed the smoke_test branch from f491b1a to 2cb7efa Compare October 21, 2025 07:14

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 22, 2026

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 21, 2026

Conversation

henry3260 commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 18, 2025

Uh oh!

k8s-ci-robot commented Oct 18, 2025

Uh oh!

minikube-bot commented Oct 18, 2025

Uh oh!

nirs left a comment

Choose a reason for hiding this comment

Uh oh!

nirs Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

henry3260 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

nirs Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

nirs Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

medyagh Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

medyagh Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

henry3260 Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Dec 22, 2025

Uh oh!

k8s-triage-robot commented Mar 22, 2026

Uh oh!

k8s-triage-robot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

henry3260 commented Oct 18, 2025 •

edited

Loading

henry3260 Oct 21, 2025 •

edited

Loading