Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Run AI workloads on Macbook's GPU in Kubernetes using the new `krunkit driver`.
* Don't call startKicServiceTunnel for non-kic drivers (#20863)
* krunkit: Disable offloading for faster networking (#21341)

## Deprication
## Deprecation

* Deprecate HyperKit driver with warning (#21024)

Expand Down Expand Up @@ -379,7 +379,7 @@ Improvements:
* Improved error message when enabling KVM addons on non-KVM cluster [#19195](https://github.com/kubernetes/minikube/pull/19195)
* Added warning when loading image with wrong arch [#19229](https://github.com/kubernetes/minikube/pull/19229)
* `profile list --output json` handle empty config folder [#16900](https://github.com/kubernetes/minikube/pull/16900)
* Check connectivity outside minikube when connectivity issuse [#18859](https://github.com/kubernetes/minikube/pull/18859)
* Check connectivity outside minikube when connectivity issues [#18859](https://github.com/kubernetes/minikube/pull/18859)

Bugs:

Expand Down Expand Up @@ -813,7 +813,7 @@ Minor Improvements:
* Hyper-V: Add memory validation for odd numbers [#17325](https://github.com/kubernetes/minikube/pull/17325)
* QEMU: Improve cpu type and IP detection [#17217](https://github.com/kubernetes/minikube/pull/17217)
* Mask http(s)_proxy password from startup output [#17116](https://github.com/kubernetes/minikube/pull/17116)
* `--delete-on-faliure` also recreates cluster for kubeadm failures [#16890](https://github.com/kubernetes/minikube/pull/16890)
* `--delete-on-failure` also recreates cluster for kubeadm failures [#16890](https://github.com/kubernetes/minikube/pull/16890)
* Addon auto-pause: Configure intervals using `--auto-pause-interval` [#17070](https://github.com/kubernetes/minikube/pull/17070)
* `--kubernetes-version` checks GitHub for version validation and improved error output for invalid versions [#16865](https://github.com/kubernetes/minikube/pull/16865)

Expand Down Expand Up @@ -1588,7 +1588,7 @@ Minor Improvements:
* Limit number of audit entries [#14695](https://github.com/kubernetes/minikube/pull/14695)
* Optimize audit logging [#14596](https://github.com/kubernetes/minikube/pull/14596)
* Show the container runtime when running without kubernetes #13432 [#14200](https://github.com/kubernetes/minikube/pull/14200)
* Add warning when enabling thrid-party addons [#14499](https://github.com/kubernetes/minikube/pull/14499)
* Add warning when enabling third-party addons [#14499](https://github.com/kubernetes/minikube/pull/14499)

Bug fixes:

Expand Down Expand Up @@ -3730,7 +3730,7 @@ Minor Improvements:
* docker-env: restart dockerd inside minikube on failure [#8239](https://github.com/kubernetes/minikube/pull/8239)
* wait for kubernetes components on soft start [#8199](https://github.com/kubernetes/minikube/pull/8199)
* improve minikube status display for one node [#8238](https://github.com/kubernetes/minikube/pull/8238)
* improve solution message for wrong kuberentes-version format [#8118](https://github.com/kubernetes/minikube/pull/8118)
* improve solution message for wrong kubernetes-version format [#8118](https://github.com/kubernetes/minikube/pull/8118)

Bug fixes:

Expand Down Expand Up @@ -4024,7 +4024,7 @@ New features & improvements

Bug Fixes

* Re-initalize failed Kubernetes clusters [#7234](https://github.com/kubernetes/minikube/pull/7234)
* Re-initialize failed Kubernetes clusters [#7234](https://github.com/kubernetes/minikube/pull/7234)
* do not override hostname if extraConfig is specified [#7238](https://github.com/kubernetes/minikube/pull/7238)
* Enable HW_RANDOM_VIRTIO to fix sshd startup delays [#7208](https://github.com/kubernetes/minikube/pull/7208)
* hyperv Delete: call StopHost before removing VM [#7160](https://github.com/kubernetes/minikube/pull/7160)
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ MARKDOWNLINT ?= markdownlint
MINIKUBE_MARKDOWN_FILES := README.md CONTRIBUTING.md CHANGELOG.md

# The `libvirt_dlopen` build tag is used only linux to avoid linking with
# libvirt shared library. This is not documnted but can be found in the source.
# libvirt shared library. This is not documented but can be found in the source.
# https://gitlab.com/libvirt/libvirt-go-module/-/blob/f7cdeba9979dd248582901d2aaf7ab1f2d27cbe0/domain.go#L30
MINIKUBE_BUILD_TAGS := libvirt_dlopen

Expand Down Expand Up @@ -1067,7 +1067,7 @@ update-portainer-version:

# used by update- Targets to get before/after versions of tools it updates
# example usage echo "OLD_VERSION=$(DEP=node make get-dependency-version)" >> "$GITHUB_OUTPUT"
.PHONY: get-dependency-verison
.PHONY: get-dependency-version
get-dependency-version:
@(cd hack && go run update/get_version/get_version.go)

Expand Down
2 changes: 1 addition & 1 deletion cmd/minikube/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ var RootCmd = &cobra.Command{
klog.Warningf("failed to log command start to audit: %v", err)
}
// viper maps $MINIKUBE_ROOTLESS to "rootless" property automatically, but it does not do vice versa,
// so we map "rootless" property to $MINIKUBE_ROOTLESS expliclity here.
// so we map "rootless" property to $MINIKUBE_ROOTLESS explicitly here.
// $MINIKUBE_ROOTLESS is referred by KIC runner, which is decoupled from viper.
if viper.GetBool(config.Rootless) {
os.Setenv(constants.MinikubeRootlessEnv, "true")
Expand Down
2 changes: 1 addition & 1 deletion cmd/minikube/cmd/update-context.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ var updateContextCmd = &cobra.Command{
options := flags.CommandOptions()
cname := ClusterFlagValue()
co := mustload.Running(cname, options)
// cluster extension metada for kubeconfig
// cluster extension metadata for kubeconfig

updated, err := kubeconfig.UpdateEndpoint(cname, co.CP.Hostname, co.CP.Port, kubeconfig.PathFromEnv(), kubeconfig.NewExtension())
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion deploy/addons/registry-aliases/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Minikube Registry Aliases Addon

An addon to minikube that can help push and pull from the minikube registry using custom domain names. The custom domain names will be made resolveable from with in cluster and at minikube node.
An addon to minikube that can help push and pull from the minikube registry using custom domain names. The custom domain names will be made resolveble from with in cluster and at minikube node.

## How to use ?

Expand Down
4 changes: 2 additions & 2 deletions deploy/kicbase/entrypoint
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ validate_userns() {
fi
}

overlayfs_preferrable() {
overlayfs_preferable() {
if [[ -z "$userns" ]]; then
# If we are outside userns, we can always assume overlayfs is preferable
return 0
Expand Down Expand Up @@ -108,7 +108,7 @@ configure_containerd() {
# enable restrict_oom_score_adj
sed -i 's/restrict_oom_score_adj = false/restrict_oom_score_adj = true/' /etc/containerd/config.toml
# Use fuse-overlayfs if overlayfs is not preferable: https://github.com/kubernetes-sigs/kind/issues/2275
if [[ -z "$snapshotter" ]] && ! overlayfs_preferrable; then
if [[ -z "$snapshotter" ]] && ! overlayfs_preferable; then
snapshotter="fuse-overlayfs"
fi
fi
Expand Down
42 changes: 21 additions & 21 deletions hack/benchmark/image-build/generate-chart.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ var RuntimeMethods = map[string][]string{
}

const (
INTERATIVE = "Iterative"
NONINTERATIVE = "NonIterative"
ITERATIVE = "Iterative"
NONITERATIVE = "NonIterative"
)

var Itrs = []string{
INTERATIVE,
// to simplify the output, non-interative is omitted
// NONINTERATIVE,
ITERATIVE,
// to simplify the output, non-iterative is omitted
// NONITERATIVE,
}

// method name-> test result
Expand Down Expand Up @@ -134,8 +134,8 @@ func readInLatestTestResult(latestBenchmarkPath string) ItrTestResults {
var res = ItrTestResults{
Results: make(map[string]ImageTestResults),
}
res.Results[INTERATIVE] = make(ImageTestResults)
res.Results[NONINTERATIVE] = make(ImageTestResults)
res.Results[ITERATIVE] = make(ImageTestResults)
res.Results[NONITERATIVE] = make(ImageTestResults)

f, err := os.Open(latestBenchmarkPath)
if err != nil {
Expand All @@ -157,43 +157,43 @@ func readInLatestTestResult(latestBenchmarkPath string) ItrTestResults {
continue
}

valuesInterative := []float64{}
valuesNonInterative := []float64{}
// interative test results of each env are stored in the following columns
indicesInterative := []int{1, 5, 9, 13, 17, 21, 25, 29, 33, 37, 41, 45, 49, 53}
// non-interative test results of each env are stored in the following columns
indicesNonInterative := []int{3, 7, 11, 15, 19, 23, 27, 31, 35, 39, 43, 47, 51, 55}
valuesIterative := []float64{}
valuesNonIterative := []float64{}
// iterative test results of each env are stored in the following columns
indicesIterative := []int{1, 5, 9, 13, 17, 21, 25, 29, 33, 37, 41, 45, 49, 53}
// non-iterative test results of each env are stored in the following columns
indicesNonIterative := []int{3, 7, 11, 15, 19, 23, 27, 31, 35, 39, 43, 47, 51, 55}

for _, i := range indicesInterative {
for _, i := range indicesIterative {
if line[i] == "NaN" {
// we use -1 as invalid value
valuesInterative = append(valuesInterative, -1)
valuesIterative = append(valuesIterative, -1)
continue
}
v, err := strconv.ParseFloat(line[i], 64)
if err != nil {
log.Fatal(err)
}
valuesInterative = append(valuesInterative, v)
valuesIterative = append(valuesIterative, v)
}

for _, i := range indicesNonInterative {
for _, i := range indicesNonIterative {
if line[i] == "NaN" {
// we use -1 as invalid value
valuesNonInterative = append(valuesNonInterative, -1)
valuesNonIterative = append(valuesNonIterative, -1)
continue
}
v, err := strconv.ParseFloat(line[i], 64)
if err != nil {
log.Fatal(err)
}
valuesNonInterative = append(valuesNonInterative, v)
valuesNonIterative = append(valuesNonIterative, v)
}

imageName := line[0]

res.Results[INTERATIVE][imageName] = NewTestResult(valuesInterative)
res.Results[NONINTERATIVE][imageName] = NewTestResult(valuesNonInterative)
res.Results[ITERATIVE][imageName] = NewTestResult(valuesIterative)
res.Results[NONITERATIVE][imageName] = NewTestResult(valuesNonIterative)

}

Expand Down
2 changes: 1 addition & 1 deletion hack/benchmark/time-to-k8s/page.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func main() {
apps := make(map[string]runs)

if err := readInCSV(*csvPath, apps); err != nil {
log.Fatalf("fail to readin cvs file with err %s", err)
log.Fatalf("fail to read in cvs file with err %s", err)
}

runningTime, cpuMdPlot, cpuChartPlot, totals, names := values(apps)
Expand Down
2 changes: 1 addition & 1 deletion hack/jenkins/build_iso.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ sudo apt-get -y install build-essential unzip rsync bc python3 p7zip-full cmake
CMAKE_VERSION=$(cmake --version | head -n1 | awk '{print $3}')
echo "Start of ISO build: CMake version: $CMAKE_VERSION"
if dpkg --compare-versions "$CMAKE_VERSION" lt "3.20"; then
echo "WARNING: CMake version $CMAKE_VERSION is less than 3.20. this will cause a slower build due to rebuidling cmake ..."
echo "WARNING: CMake version $CMAKE_VERSION is less than 3.20. this will cause a slower build due to rebuilding cmake ..."
fi

# Let's make sure we have the newest ISO reference
Expand Down
4 changes: 2 additions & 2 deletions hack/prow/minitest/deployer/boskos_deployer.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ type MiniTestBosKosDeployer struct {
sshAddr string

boskosClient *client.Client
// this channel serves as a signal channel for the hearbeat goroutine
// this channel serves as a signal channel for the heartbeat goroutine
// so that it can be explicitly closed
boskosHeartbeatClose chan struct{}
}
Expand Down Expand Up @@ -104,7 +104,7 @@ func (m *MiniTestBosKosDeployer) Up() error {
return err
}
if err := sshConnectionCheck(m.ctx, m.remoteUserName, m.sshAddr, nil); err != nil {
klog.Errorf("Failed to conntect via ssh: %v", err)
klog.Errorf("Failed to connect via ssh: %v", err)
return err
}

Expand Down
4 changes: 2 additions & 2 deletions hack/prow/minitest/deployer/docker_deployer.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ func (m *MiniTestDockerDeployer) Up() error {

// check ssh connectivity
if err := sshConnectionCheck(m.ctx, m.remoteUserName, "localhost", m.sshAdditionalArgs()); err != nil {
klog.Errorf("Failed to conntect via ssh: %v", err)
return fmt.Errorf("Failed to conntect via ssh: %v", err)
klog.Errorf("Failed to connect via ssh: %v", err)
return fmt.Errorf("Failed to connect via ssh: %v", err)
}

m.isUp = true
Expand Down
2 changes: 1 addition & 1 deletion pkg/drivers/common/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ func parseDHCPdLeasesFile(file io.Reader) ([]DHCPEntry, error) {
}

// parseMAC parse both standard fixed size MAC address "%02x:..." and the
// variable size MAC address on drawin "%x:...".
// variable size MAC address on Darwin "%x:...".
func parseMAC(mac string) (net.HardwareAddr, error) {
hw := make(net.HardwareAddr, 6)
n, err := fmt.Sscanf(mac, "%x:%x:%x:%x:%x:%x",
Expand Down
2 changes: 1 addition & 1 deletion pkg/drivers/kic/oci/oci.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func CreateContainerNode(p CreateParams) error { //nolint to suppress cyclomatic
"--security-opt", "seccomp=unconfined", // ignore seccomp
"--tmpfs", "/tmp", // various things depend on working /tmp
"--tmpfs", "/run", // systemd wants a writable /run
// logs,pods be stroed on filesystem vs inside container,
// logs,pods be stored on filesystem vs inside container,
// some k8s things want /lib/modules
"-v", fmt.Sprintf("%s:/lib/modules:ro", kernelModulesPath()),
"--hostname", p.Name, // make hostname match container name
Expand Down
2 changes: 1 addition & 1 deletion pkg/drivers/krunkit/krunkit.go
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ func (d *Driver) stopKrunkit() error {
// No pidfile.
return nil
}
log.Debugf("Terminte krunkit (pid=%d)", pid)
log.Debugf("Terminate krunkit (pid=%d)", pid)
if err := process.Terminate(pid, driverName); err != nil {
if err != os.ErrProcessDone {
return err
Expand Down
2 changes: 1 addition & 1 deletion pkg/drivers/parallels/parallels_darwin.go
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ func (d *Driver) GetCreateFlags() []mcnflag.Flag {
},
mcnflag.BoolFlag{
Name: "parallels-nested-virtualization",
Usage: "Enable nested virutalization",
Usage: "Enable nested virtualization",
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/drivers/virtualbox/network_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func TestGetHostOnlyNetworkNotFound(t *testing.T) {
}

// Tests a special case where Virtualbox creates the host only network
// successfully but mis-reports the netmask.
// successfully but miss-reports the netmask.
func TestGetHostOnlyNetworkWindows10Bug(t *testing.T) {
cidr := "192.168.99.0/24"
ip, ipnet, err := net.ParseCIDR(cidr)
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/assets/addons_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func TestFilterKeySpace(t *testing.T) {
}
}

func TestOverrideDefautls(t *testing.T) {
func TestOverrideDefaults(t *testing.T) {
type TestCase struct {
defaultMap map[string]string
overrideMap map[string]string
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/assets/vm_assets.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ func (f *FileAsset) Seek(offset int64, whence int) (int64, error) {
return f.reader.Seek(offset, whence)
}

// Close closes the opend file.
// Close closes the opened file.
func (f *FileAsset) Close() error {
if f.file == nil {
return nil
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/bootstrapper/certs.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func SetupCerts(k8s config.ClusterConfig, n config.Node, pcpCmd command.Runner,
}

for src, dst := range caCerts {
// note: these are all public certs, so should be world-readeable
// note: these are all public certs, so should be world-readable
// note: src is user os' path, dst is kic/iso (linux) path
certFile, err := assets.NewFileAsset(src, path.Dir(dst), path.Base(dst), "0644")
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/bootstrapper/kubeadm/kubeadm.go
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ func (k *Bootstrapper) restartPrimaryControlPlane(cfg config.ClusterConfig) erro
return err
}
if err = retry.Expo(addonPhase, 100*time.Microsecond, 30*time.Second); err != nil {
klog.Warningf("addon install failed, wil retry: %v", err)
klog.Warningf("addon install failed, will retry: %v", err)
return fmt.Errorf("addons: %w", err)
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/cruntime/crio.go
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ func (r *CRIO) Preload(cc config.ClusterConfig) error {
// Double check if there are any images in the runtime to avoid data loss on restart
// The crio preload tarball is a filesystem dump that overwrites /var
// we backup and restore any existing images
// simmilar to docker runtime implemented in pkg/minikube/cruntime/docker.go.
// similar to docker runtime implemented in pkg/minikube/cruntime/docker.go.
// It uses a special helper (pkg/minikube/docker/store.go) to explicitly save and merge the repositories.json file (Docker's image index)
// before and after the tarball extraction.
allImages, err := r.ListImages(ListImagesOptions{})
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/download/gh/gh.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
)

// ReleaseAssets retrieves a GitHub release by tag from org/project.
// Try to not call this too often. preferably cache and re-use. to avoid rate limits.
// Try to not call this too often. preferably cache and reuse. to avoid rate limits.
func ReleaseAssets(org, project, tag string) ([]*github.ReleaseAsset, error) {
ctx := context.Background()
// Use an authenticated client when GITHUB_TOKEN is set to avoid low rate limits.
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/mustload/mustload.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ type ControlPlane struct {
Node *config.Node
// Runner provides command execution
Runner command.Runner
// Hostname is the host-accesible target for the apiserver
// Hostname is the host-accessible target for the apiserver
Hostname string
// Port is the host-accessible port for the apiserver
Port int
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/out/out_style_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func TestApplyStyle(t *testing.T) {
}
}

func TestApplyTemplateFormating(t *testing.T) {
func TestApplyTemplateFormatting(t *testing.T) {
tests := []struct {
expected string
description string
Expand Down
6 changes: 3 additions & 3 deletions pkg/minikube/registry/drvs/kvm2/kvm2.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const (

// The driver is implemented for amd64 and arm64, but we cannot build the arm64
// version yet: https://github.com/kubernetes/minikube/issues/19959.
var supportedArchictures = []string{"amd64"}
var supportedArchitectures = []string{"amd64"}

func init() {
if err := registry.Register(registry.DriverDef{
Expand Down Expand Up @@ -105,10 +105,10 @@ func defaultURI() string {
}

func status(_ *run.CommandOptions) registry.State {
if !slices.Contains(supportedArchictures, runtime.GOARCH) {
if !slices.Contains(supportedArchitectures, runtime.GOARCH) {
rs := registry.State{
Error: fmt.Errorf("KVM is not supported on %q, contributions are welcome", runtime.GOARCH),
Fix: fmt.Sprintf("you can use the KVM driver on %s", strings.Join(supportedArchictures, ",")),
Fix: fmt.Sprintf("you can use the KVM driver on %s", strings.Join(supportedArchitectures, ",")),
}
// The driver is implemented but we cannot build it yet.
if runtime.GOARCH == "arm64" {
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/service/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,7 @@ func TestWaitAndMaybeOpenService(t *testing.T) {
}
}

func TestWaitAndMaybeOpenServiceForNotDefaultNamspace(t *testing.T) {
func TestWaitAndMaybeOpenServiceForNotDefaultNamespace(t *testing.T) {
initializeMockObjects()

defaultAPI := &tests.MockAPI{
Expand Down
Loading