-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix misleading Docker Desktop references in error messages #22312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: syscl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @syscl! |
|
Hi @syscl. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
medyagh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@syscl can you plz put an example output in the PR description. both Before and After this PR?
The problem is I didn't have docker desktop installed on my macOS, but it shows this confused information. The problem is the function assume people use docker desktop on macOS / Windows unconditionally, which is inaccurate and confused for debugging. This improves this logic handling.
The fix detects actual Docker runtime instead of assuming
Docker Desktop on macOS/Windows. Updates
IsDockerDesktop()to query daemoninfo and
FullName()to return the actual runtime name for accurate errormessages.