Skip to content

fix: kubevirt addon by removing curl dependency#22557

Merged
medyagh merged 2 commits intokubernetes:masterfrom
adilwiser:fix-kubevirt-addon-curl
Jan 27, 2026
Merged

fix: kubevirt addon by removing curl dependency#22557
medyagh merged 2 commits intokubernetes:masterfrom
adilwiser:fix-kubevirt-addon-curl

Conversation

@adilwiser
Copy link
Copy Markdown
Contributor

@adilwiser adilwiser commented Jan 25, 2026

fixes #15918

reference: #15918 (comment)

so basically the kubevirt addon was broken and the limitation was also on the official docs here because the bitnami/kubectl image no longer includes curl. i tried fixing stuffs and it works perfect now :D

now this PR improves how KubeVirt is managed by applying manifests directly from URLs using kubectl’s native support, eliminating the need to download them first. It pins the KubeVirt version to v1.7.0 for better reliability and consistency, adds an automated script to update the pinned version, and introduces a Makefile target to run that update easily. The PR also integrates KubeVirt into dependency version tracking and re-enables kubectl version handling that was previously disabled due to an issue.

@medyagh here is the output of minikube with the addon as requested:

before -
image

after -
image

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 25, 2026
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jan 25, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adilwiser
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @adilwiser!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @adilwiser. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 25, 2026
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 25, 2026
@adilwiser adilwiser force-pushed the fix-kubevirt-addon-curl branch from ddf6ff5 to 2d62731 Compare January 25, 2026 23:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 25, 2026
Copy link
Copy Markdown
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please add output of minikube with the addon before/after this PR

@@ -0,0 +1,86 @@
/*
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adilwiser thank you for this fix please also add an github action simmilar to this so it bumps it automatically
https://github.com/kubernetes/minikube/blob/master/.github/workflows/update-yakd-version.yml

and please verify manually that updater works

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing me in that direction! I'll address it asap!

@adilwiser
Copy link
Copy Markdown
Contributor Author

@medyagh the updater works !!

image

@medyagh medyagh self-requested a review January 26, 2026 00:35
@medyagh
Copy link
Copy Markdown
Member

medyagh commented Jan 26, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2026
@medyagh
Copy link
Copy Markdown
Member

medyagh commented Jan 26, 2026

/ok-to-extra-test

@minikube-pr-bot

This comment has been minimized.

Signed-off-by: Adil <179269350+adilwiser@users.noreply.github.com>
Signed-off-by: Adil <179269350+adilwiser@users.noreply.github.com>
@adilwiser adilwiser force-pushed the fix-kubevirt-addon-curl branch from 47ad144 to 71c4568 Compare January 26, 2026 09:16
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22557 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 38.3s    │ 37.8s                  │
│ enable ingress │ 15.9s    │ 15.9s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 37.2s 39.8s 39.7s 35.9s 38.9s
Times for minikube (PR 22557) start: 39.9s 36.2s 36.1s 39.7s 36.9s

Times for minikube ingress: 15.8s 15.2s 16.3s 16.3s 15.8s
Times for minikube (PR 22557) ingress: 16.3s 15.8s 15.8s 15.8s 15.7s

docker driver with docker runtime

┌───────────────────┬──────────┬────────────────────────┐
│      COMMAND      │ MINIKUBE │ MINIKUBE  ( PR 22557 ) │
├───────────────────┼──────────┼────────────────────────┤
│ minikube start    │ 20.2s    │ 21.1s                  │
│ ⚠️  enable ingress │ 11.1s    │ 23.2s ⚠️                │
└───────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 21.2s 21.6s 18.1s 18.5s 21.5s
Times for minikube (PR 22557) start: 19.0s 22.3s 21.3s 21.2s 21.5s

Times for minikube ingress: 10.7s 10.7s 10.7s 10.7s 12.7s
Times for minikube (PR 22557) ingress: 10.7s 73.2s 10.7s 10.7s 10.7s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22557 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 18.5s    │ 18.8s                  │
│ enable ingress │ 23.8s    │ 23.4s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 19.3s 19.4s 17.4s 19.6s 16.8s
Times for minikube (PR 22557) start: 19.1s 19.6s 19.4s 19.7s 16.4s

Times for minikube ingress: 23.2s 23.2s 24.2s 23.2s 25.2s
Times for minikube (PR 22557) ingress: 23.2s 23.2s 23.2s 23.2s 24.2s

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 26, 2026

@adilwiser: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-docker-containerd-linux-x86 71c4568 link true /test integration-docker-containerd-linux-x86
integration-docker-docker-linux-x86 71c4568 link true /test integration-docker-docker-linux-x86
integration-docker-docker-linux-arm 71c4568 link true /test integration-docker-docker-linux-arm
integration-kvm-docker-linux-x86 71c4568 link true /test integration-kvm-docker-linux-x86
integration-docker-crio-linux-x86 71c4568 link false /test integration-docker-crio-linux-x86
pull-minikube-docker-docker-linux-x86 71c4568 link true /test pull-minikube-docker-docker-linux-x86
pull-minikube-docker-docker-linux-arm 71c4568 link true /test pull-minikube-docker-docker-linux-arm
pull-minikube-kvm-docker-linux-x86 71c4568 link true /test pull-minikube-kvm-docker-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@medyagh medyagh merged commit e028c44 into kubernetes:master Jan 27, 2026
44 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KubeVirt Addon broken due to missing curl in Pod

5 participants