fix: kubevirt addon by removing curl dependency#22557
fix: kubevirt addon by removing curl dependency#22557medyagh merged 2 commits intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adilwiser The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @adilwiser! |
|
Hi @adilwiser. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
ddf6ff5 to
2d62731
Compare
medyagh
left a comment
There was a problem hiding this comment.
also please add output of minikube with the addon before/after this PR
| @@ -0,0 +1,86 @@ | |||
| /* | |||
There was a problem hiding this comment.
@adilwiser thank you for this fix please also add an github action simmilar to this so it bumps it automatically
https://github.com/kubernetes/minikube/blob/master/.github/workflows/update-yakd-version.yml
and please verify manually that updater works
There was a problem hiding this comment.
thanks for pointing me in that direction! I'll address it asap!
|
@medyagh the updater works !!
|
|
/ok-to-test |
|
/ok-to-extra-test |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Adil <179269350+adilwiser@users.noreply.github.com>
Signed-off-by: Adil <179269350+adilwiser@users.noreply.github.com>
47ad144 to
71c4568
Compare
|
kvm2 driver with docker runtime DetailsTimes for minikube start: 37.2s 39.8s 39.7s 35.9s 38.9s Times for minikube ingress: 15.8s 15.2s 16.3s 16.3s 15.8s docker driver with docker runtime DetailsTimes for minikube start: 21.2s 21.6s 18.1s 18.5s 21.5s Times for minikube ingress: 10.7s 10.7s 10.7s 10.7s 12.7s docker driver with containerd runtime DetailsTimes for minikube start: 19.3s 19.4s 17.4s 19.6s 16.8s Times for minikube ingress: 23.2s 23.2s 24.2s 23.2s 25.2s |
|
@adilwiser: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |

fixes #15918
reference: #15918 (comment)
so basically the kubevirt addon was broken and the limitation was also on the official docs here because the bitnami/kubectl image no longer includes curl. i tried fixing stuffs and it works perfect now :D
now this PR improves how KubeVirt is managed by applying manifests directly from URLs using kubectl’s native support, eliminating the need to download them first. It pins the KubeVirt version to v1.7.0 for better reliability and consistency, adds an automated script to update the pinned version, and introduces a Makefile target to run that update easily. The PR also integrates KubeVirt into dependency version tracking and re-enables kubectl version handling that was previously disabled due to an issue.
@medyagh here is the output of minikube with the addon as requested:
before -

after -
