fix(tunnel): handle existing route on Windows gracefully#22729
fix(tunnel): handle existing route on Windows gracefully#22729VedantMadane wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: VedantMadane The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @VedantMadane. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
33283e5 to
b3821ac
Compare
The tunnel route command on Windows can fail when a route already exists. Instead of parsing stderr output, check the command exit code directly for more reliable success detection. Also handle the 'route already exists' case gracefully by treating it as a non-fatal condition.
b3821ac to
995898b
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #11645
On Windows, the route ADD command returns exit code 0 even when the route already exists. This causes minikube tunnel to infinitely retry adding the same route.
Fix by checking the output message for 'already exists' indication and treating it as success (making EnsureRouteIsAdded truly idempotent).
The issue manifests when running \minikube tunnel --cleanup\ on Windows - it gets stuck in a retry loop instead of completing successfully.
Testing