cmd/config: remove duplicate Header call in addon images table#22871
cmd/config: remove duplicate Header call in addon images table#22871zxuhan wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zxuhan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @zxuhan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
printAddonImagesTableincmd/minikube/cmd/config/images.gocallstable.Header(...)twice in a row with identical content — once with a slice, then again with varargs. The second call overrides the first, so the slice-form call is dead code. Introduced by the table-rendering refactor in #20893.Removing the unused slice-form call keeps the file consistent with every other
table.Header(...)call site in the tree (addons_list.go,profile_list.go,cache_images.go, etc.), which all use the varargs form.Test plan
go build ./cmd/minikube/...go test ./cmd/minikube/cmd/config/...