Skip to content

crio: use V2 registries.conf with unqualified-search-registries#22872

Open
zxuhan wants to merge 1 commit intokubernetes:masterfrom
zxuhan:fix-crio-unqualified-search-registries
Open

crio: use V2 registries.conf with unqualified-search-registries#22872
zxuhan wants to merge 1 commit intokubernetes:masterfrom
zxuhan:fix-crio-unqualified-search-registries

Conversation

@zxuhan
Copy link
Copy Markdown

@zxuhan zxuhan commented Apr 21, 2026

Fixes #19396.

Problem

Newer CRI-O versions (v1.35+) only parse the V2 TOML format of /etc/containers/registries.conf. The legacy V1 format ([registries.search] blocks) is silently ignored, leaving unqualified-search-registries unset.

As a result, deploying an image without a registry prefix fails:

kubectl create deployment hello-minikube --image=kicbase/echo-server:1.0
# → Failed to inspect image "kicbase/echo-server:1.0": short-name did not resolve
#   to an alias and no unqualified-search registries are defined in
#   "/etc/containers/registries.conf"

Fix

Unify the registries.conf shipped to both the ISO and kicbase on the V2 format, with docker.io as the sole unqualified search registry (matches prior behavior intent).

  • deploy/iso/minikube-iso/package/crio-bin/registries.conf — migrated V1 → V2. Installed into the ISO via crio-bin.mk at /etc/containers/registries.conf.
  • deploy/kicbase/registries.conf — new file, same V2 content.
  • deploy/kicbase/DockerfileCOPY registries.conf /etc/containers/registries.conf, so the kicbase image no longer relies on whatever the cri-o Debian package happens to ship (which, on v1.35, doesn't set unqualified-search-registries).

Both paths now produce the same behavior:

unqualified-search-registries = ["docker.io"]

Test plan

  • go build ./... passes.
  • Diff reviewed — crio-bin.mk already installs the ISO registries.conf to /etc/containers/registries.conf, no mk changes needed.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zxuhan
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @zxuhan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2026
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRIO: add docker.io to the unqualified-search-registries

3 participants